Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Respect sorting from the file list in the preview app #8806

Merged
merged 4 commits into from
Apr 14, 2023
Merged

Respect sorting from the file list in the preview app #8806

merged 4 commits into from
Apr 14, 2023

Conversation

JammingBen
Copy link
Collaborator

@JammingBen JammingBen commented Apr 13, 2023 •
edited
Loading

Description

  • Adds sorting to the preview app
  • Refactors the code and splits up App.vue into smaller components

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

@JammingBen JammingBen self-assigned this Apr 13, 2023
@ownclouders
Copy link
Contributor

ownclouders commented Apr 13, 2023 •
edited
Loading

Results for acceptance oCIS https://drone.owncloud.com/owncloud/web/34694/62/1
💥 The oCISSharingAutocompletionResharing tests pipeline failed. The build has been cancelled.

@ownclouders
Copy link
Contributor

Results for acceptance oCIS https://drone.owncloud.com/owncloud/web/34691/64/1
💥 The oCISSharingPerm2 tests pipeline failed. The build has been cancelled.

@ownclouders
Copy link
Contributor

Results for acceptance oC10 https://drone.owncloud.com/owncloud/web/34691/71/1
💥 The oC10IntegrationApp2 tests pipeline failed. The build has been cancelled.

@ownclouders
Copy link
Contributor

Results for acceptance oC10 https://drone.owncloud.com/owncloud/web/34691/70/1
💥 The oC10IntegrationApp1 tests pipeline failed. The build has been cancelled.

@ownclouders
Copy link
Contributor

Results for acceptance oCIS https://drone.owncloud.com/owncloud/web/34691/68/1
💥 The oCISUploadMove tests pipeline failed. The build has been cancelled.

@ownclouders
Copy link
Contributor

Results for acceptance oCIS https://drone.owncloud.com/owncloud/web/34691/65/1
💥 The oCISSharingPublic1 tests pipeline failed. The build has been cancelled.

@ownclouders
Copy link
Contributor

Results for acceptance oCIS https://drone.owncloud.com/owncloud/web/34691/69/1
💥 The oCISTrashbinJourney tests pipeline failed. The build has been cancelled.

@ownclouders
Copy link
Contributor

Results for acceptance oCIS https://drone.owncloud.com/owncloud/web/34691/67/1
💥 The oCISSharingPublic3 tests pipeline failed. The build has been cancelled.

@sonarcloud
Copy link

sonarcloud bot commented Apr 13, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 1 Bug
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 7 Code Smells

75.0% 75.0% Coverage
0.0% 0.0% Duplication

dschmidt
dschmidt reviewed Apr 13, 2023
View reviewed changes
packages/web-app-preview/src/App.vue
query: { ...unref(route).query, ...query }
})
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like where this PR is going!

It doesn't need to be implemented in this PR and it probably makes sense to do it, when we introduce another app that needs it, but long term I would really like to separate this logic from the app.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not 100% sure where your comment belongs to, it kinda sits at the end of updateLocalHistory - you mean that method in general? 😄

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nah, all of that file switching, route, filtering logic.

I would like to implement just the filter in this app and have eVerything else handled by a composable

@JammingBen JammingBen marked this pull request as ready for review April 13, 2023 15:37
kulmann
kulmann approved these changes Apr 14, 2023
View reviewed changes
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woah nice 😍

@kulmann kulmann merged commit 672c577 into master Apr 14, 2023
@delete-merged-branch delete-merged-branch bot deleted the preview-app-sorting branch April 14, 2023 09:55
@micbar micbar mentioned this pull request May 3, 2023
Closed
89 tasks
@ScharfViktor ScharfViktor mentioned this pull request May 4, 2023
Closed
86 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dschmidt dschmidt dschmidt left review comments

@kulmann kulmann kulmann approved these changes

Assignees

@JammingBen JammingBen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

preview app: respect sorting from file list Clean up media viewer code
4 participants
@JammingBen @ownclouders @dschmidt @kulmann