Fix quicklink icon alignment #8822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kulmann
reviewed
Apr 17, 2023
packages/web-app-files/src/components/SideBar/Shares/Links/DetailsAndEdit.vue
Outdated
Show resolved
Hide resolved
kulmann
requested changes
Apr 17, 2023
Am I wrong or are these two different icons for the same thing (expiration date)?
and
|
|
@ChrisEdS correct, good spot. Let’s only use one. 🙈 I prefer the one we have for links. You? |
|
Yep, seems like the one without the "date picked" is used as "remove date" icon
|
|
ok will look into it when i'm done with the other ticket |
|
done |
lookacat
force-pushed
the
enhancement-fix-quicklink-icon-alignment
branch
from
68887aa
to
c091d9e
Compare
AlexAndBear
reviewed
Apr 21, 2023
packages/web-app-files/src/components/SideBar/Shares/Collaborators/ListItem.vue
Show resolved
Hide resolved
AlexAndBear
requested changes
Apr 21, 2023
packages/web-app-files/src/components/SideBar/Shares/Links/DetailsAndEdit.vue
Outdated
Show resolved
Hide resolved
lookacat
force-pushed
the
enhancement-fix-quicklink-icon-alignment
branch
from
c091d9e
to
1d5cf33
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
AlexAndBear
approved these changes
Apr 26, 2023
delete-merged-branch
bot
deleted the
enhancement-fix-quicklink-icon-alignment
branch
86 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We've fixed the alignment of the quicklink icons.
(There is no better solution but to hard set pixel values because the icons itself have the exact same size and padding, its just because of the form of the icons that it looks like the padding is wrong)
For more details see #8606
Related Issue
Types of changes
Checklist: