Remove drop target in read-only folders #8825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
SonarCloud Quality Gate failed. |
kulmann
approved these changes
Apr 17, 2023
There was a problem hiding this comment.
I see another chance for improvement, but that can/should happen in a followup:
Both the read only public link view and the read only share view suggest to the user that they can drag & drop files for upload when navigating into an empty folder (see screenshots). That subtitle of the No resources found message could be removed on read only folders. But again, also fine as a followup.
This PR itself LGTM 💪
|
Ohhh yeah, good catch! I've created #8834 for this. |
delete-merged-branch
bot
deleted the
remove-drop-target-in-read-only-folders
branch
86 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes the drop target in read-only folders
Related Issue
Types of changes