Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: validator key not being used #335

Merged
merged 2 commits into from
Nov 13, 2023

Conversation

byte-bandit
Copy link
Collaborator

@byte-bandit byte-bandit commented Nov 13, 2023

The new validator key config wasn't used throughout the project. This fixes the issue and also adapts the documentation to how it needs to be when creating new signing keys for pigeon.

Copy link
Contributor

@taariq taariq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to require a minimum of keys? Why 3 instead of 5?

@byte-bandit
Copy link
Collaborator Author

Do we want to require a minimum of keys? Why 3 instead of 5?

There is no minimum or maximum enforced. It's up to validators to decide how many keys they want to juggle. More keys means less likelihood of account sequence errors.

@byte-bandit byte-bandit merged commit 4a8ea97 into palomachain:master Nov 13, 2023
2 checks passed
@byte-bandit byte-bandit deleted the clohr/validator-key-fix branch November 13, 2023 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants