fix: gas limit from estimation #447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maharifu
force-pushed
the
fix/gas_limit_from_estimation
branch
from
6ed47ba
to
d72534a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Github tickets
Background
Before calling compass, pigeons get a gas estimate for the transaction. This estimate is used to pay pigeons. However, just before sending the transaction the relayer pigeon will get another gas estimate. If this latter estimate is lower than the agreed, the tx is unsuccessful since we don't have enough gas to pay the relayer.
This PR changes this last estimate to be equal to the agreed estimate if higher.
Also revert palomachain/paloma#1305. The gas-adjustment parameter is already configurable on pigeon's config.yaml. Validators having this issue should adjust this parameter.
Testing completed
Breaking changes