Ignoring attributes is not working

[nneal]

Using paper_trail 3.0.3 and rails 4.1.5

In my model, I've tried all three of the following:

has_paper_trail ignore: [:score]

has_paper_trail ignore: [:score], skip: [:score]    

has_paper_trail skip: [:score]

My test is as such:

it 'does not add version for update score' do
  PaperTrail.enabled = true
  conversation = create(:conversation)

  # passes
  expect(PaperTrail::Version.count).to eq 1

  conversation.update_attribute(:score, 10)
  conversation.save

  # fails
  expect(PaperTrail::Version.count).to eq 1
end

Am I doing something funky or is this feature not working? Any troubleshooting ideas?

[nneal]

Okay, I solved this myself. the answer is to do:

has_paper_trail ignore: [:score, :updated_at]

A bit confusing though, would be nice to add this to docs.

[batter]

Apologies for the delayed response. Seems like it may be a bug in ActiveRecord 4.1.5, I can't reproduce with ActiveRecord 4.1.1, and we definitely have a bunch of test cases in our repo that should flesh that out.. Are you sure there's not something else going on here?

[batter]

Nevermind, I think I can reproduce this locally. Seems like it may be a change in the way ActiveModel::Dirty reports the timestamps into the changes hash. Either way, we are definitely going to need to fix this for 3.1.0 since the callbacks are now using after_ instead of before_ (see #374). Actually this probably warrants a 3.0.6 release with an immediate fix. Ugh!

[batter]

After some additional testing I can confirm that this is a change in the way that datestamps get inserted into the changes hash via ActiveModel::Dirty between 3.x and 4.x.

Here is evidence:

#  id                     :integer          not null, primary key
#  name                   :string(255)
class Model < ActiveRecord::Base
  before_update { p changed }
  after_update { p changed }
end

# ActiveRecord 3
> model.update_attribute(:name, 'foo')
(0.1ms)  SAVEPOINT active_record_1
['name']
(0.3ms)  UPDATE "models" SET "name" = 'foo', "updated_at" = '2014-10-02 06:39:10.113930' WHERE "models"."id" = 1
['name', 'updated_at']
(0.0ms)  RELEASE SAVEPOINT active_record_1
=> true

# ActiveRecord 4
> model.update_attribute(:name, 'foo')
(0.1ms)  SAVEPOINT active_record_1
['name', 'updated_at']
(0.3ms)  UPDATE "models" SET "name" = 'foo', "updated_at" = '2014-10-02 06:39:10.113930' WHERE "models"."id" = 1
['name', 'updated_at']
(0.0ms)  RELEASE SAVEPOINT active_record_1
=> true

[nneal]

Thanks! Will be much more straightforward to ignore updated_at

[batter]

Just released version 3.0.6 which has the fix for this backported to it

[nneal]

👍