Skip to content

Commit

Permalink
Drive-by, fix clap value name
Browse files Browse the repository at this point in the history
  • Loading branch information
emhane committed Aug 17, 2024
1 parent 48899a1 commit 0dd580c
Show file tree
Hide file tree
Showing 9 changed files with 12 additions and 12 deletions.
2 changes: 1 addition & 1 deletion book/cli/reth/debug/execution.md
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,7 @@ Networking:
[default: 1]
--max-seen-tx-history <MAX_SEEN_TX_HISTORY>
--max-seen-tx-history <COUNT>
Max number of seen transactions to remember per peer.
Default is 320 transaction hashes.
Expand Down
2 changes: 1 addition & 1 deletion book/cli/reth/debug/in-memory-merkle.md
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,7 @@ Networking:
[default: 1]
--max-seen-tx-history <MAX_SEEN_TX_HISTORY>
--max-seen-tx-history <COUNT>
Max number of seen transactions to remember per peer.
Default is 320 transaction hashes.
Expand Down
2 changes: 1 addition & 1 deletion book/cli/reth/debug/merkle.md
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,7 @@ Networking:
[default: 1]
--max-seen-tx-history <MAX_SEEN_TX_HISTORY>
--max-seen-tx-history <COUNT>
Max number of seen transactions to remember per peer.
Default is 320 transaction hashes.
Expand Down
2 changes: 1 addition & 1 deletion book/cli/reth/debug/replay-engine.md
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,7 @@ Networking:
[default: 1]
--max-seen-tx-history <MAX_SEEN_TX_HISTORY>
--max-seen-tx-history <COUNT>
Max number of seen transactions to remember per peer.
Default is 320 transaction hashes.
Expand Down
2 changes: 1 addition & 1 deletion book/cli/reth/node.md
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,7 @@ Networking:
[default: 1]
--max-seen-tx-history <MAX_SEEN_TX_HISTORY>
--max-seen-tx-history <COUNT>
Max number of seen transactions to remember per peer.
Default is 320 transaction hashes.
Expand Down
2 changes: 1 addition & 1 deletion book/cli/reth/p2p.md
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ Networking:
[default: 1]
--max-seen-tx-history <MAX_SEEN_TX_HISTORY>
--max-seen-tx-history <COUNT>
Max number of seen transactions to remember per peer.
Default is 320 transaction hashes.
Expand Down
2 changes: 1 addition & 1 deletion book/cli/reth/stage/run.md
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,7 @@ Networking:

[default: 1]

--max-seen-tx-history <MAX_SEEN_TX_HISTORY>
--max-seen-tx-history <COUNT>
Max number of seen transactions to remember per peer.

Default is 320 transaction hashes.
Expand Down
2 changes: 1 addition & 1 deletion book/cli/reth/stage/unwind.md
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,7 @@ Networking:
[default: 1]
--max-seen-tx-history <MAX_SEEN_TX_HISTORY>
--max-seen-tx-history <COUNT>
Max number of seen transactions to remember per peer.
Default is 320 transaction hashes.
Expand Down
8 changes: 4 additions & 4 deletions crates/node/core/src/args/network.rs
Original file line number Diff line number Diff line change
Expand Up @@ -116,8 +116,8 @@ pub struct NetworkArgs {
/// Max number of seen transactions to remember per peer.
///
/// Default is 320 transaction hashes.
#[arg(long = "max-seen-tx-history", value_name = "MAX_SEEN_TX_HISTORY", default_value_t = DEFAULT_MAX_COUNT_TRANSACTIONS_SEEN_BY_PEER, verbatim_doc_comment)]
pub max_seen_tx_history: u32,
#[arg(long = "max-seen-tx-history", value_name = "COUNT", default_value_t = DEFAULT_MAX_COUNT_TRANSACTIONS_SEEN_BY_PEER, verbatim_doc_comment)]
pub COUNT: u32,

/// Experimental, for usage in research. Sets the max accumulated byte size of transactions
/// to pack in one response.
Expand Down Expand Up @@ -186,7 +186,7 @@ impl NetworkArgs {
self.soft_limit_byte_size_pooled_transactions_response,
self.soft_limit_byte_size_pooled_transactions_response_on_pack_request,
),
max_transactions_seen_by_peer_history: self.max_seen_tx_history,
max_transactions_seen_by_peer_history: self.COUNT,
};

// Configure basic network stack
Expand Down Expand Up @@ -289,7 +289,7 @@ impl Default for NetworkArgs {
soft_limit_byte_size_pooled_transactions_response:
SOFT_LIMIT_BYTE_SIZE_POOLED_TRANSACTIONS_RESPONSE,
soft_limit_byte_size_pooled_transactions_response_on_pack_request: DEFAULT_SOFT_LIMIT_BYTE_SIZE_POOLED_TRANSACTIONS_RESP_ON_PACK_GET_POOLED_TRANSACTIONS_REQ,
max_seen_tx_history: DEFAULT_MAX_COUNT_TRANSACTIONS_SEEN_BY_PEER,
COUNT: DEFAULT_MAX_COUNT_TRANSACTIONS_SEEN_BY_PEER,
}
}
}
Expand Down

0 comments on commit 0dd580c

Please sign in to comment.