feat(ci): check all crates for Wasm #10084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shekhirin
force-pushed
the
alexey/check-wasm-all
branch
from
c10aa6c
to
fd80fca
Compare
shekhirin
force-pushed
the
alexey/check-wasm-all
branch
from
fd80fca
to
6402f1e
Compare
shekhirin
force-pushed
the
alexey/check-wasm-all
branch
2 times, most recently
from
9275f88
to
ee3c246
Compare
shekhirin
force-pushed
the
alexey/check-wasm-all
branch
from
ee3c246
to
210e470
Compare
shekhirin
added
C-enhancement
shekhirin
commented
Aug 5, 2024
Comment on lines
+69
to
+81
| # The following are not supposed to be working | ||
| reth # all of the crates below | ||
| reth-db # mdbx | ||
| reth-libmdbx # mdbx | ||
| reth-mdbx-sys # mdbx | ||
| reth-nippy-jar # sucds | ||
| reth-provider # reth-db, reth-nippy-jar | ||
| reth-prune # reth-db | ||
| reth-stages-api # reth-provider, reth-prune | ||
| reth-static-file # reth-nippy-jar | ||
| reth-transaction-pool # c-kzg | ||
| reth-trie-db # reth-db | ||
| reth-trie-parallel # reth-db |
There was a problem hiding this comment.
@mattsse can you confirm these aren't supposed to work? I'm not sure about some of them, e.g. feels like reth-transaction-pool and reth-trie-parallel should be decoupled from c-kzg and db accordingly?
There was a problem hiding this comment.
yeah but not a big deal imo
mattsse
approved these changes
Aug 5, 2024
Comment on lines
+69
to
+81
| # The following are not supposed to be working | ||
| reth # all of the crates below | ||
| reth-db # mdbx | ||
| reth-libmdbx # mdbx | ||
| reth-mdbx-sys # mdbx | ||
| reth-nippy-jar # sucds | ||
| reth-provider # reth-db, reth-nippy-jar | ||
| reth-prune # reth-db | ||
| reth-stages-api # reth-provider, reth-prune | ||
| reth-static-file # reth-nippy-jar | ||
| reth-transaction-pool # c-kzg | ||
| reth-trie-db # reth-db | ||
| reth-trie-parallel # reth-db |
There was a problem hiding this comment.
yeah but not a big deal imo
mattsse
approved these changes
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wasm32-wasip1target with--no-default-features