fix(trie): consider all intermediate nodes invalidated for wiped storage #10476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkrasiuk
added
C-bug
rkrasiuk
requested review from
Rjected,
rakita,
joshieDo and
shekhirin
as code owners
shekhirin
reviewed
Aug 23, 2024
Rjected
approved these changes
Aug 23, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
rkrasiuk
force-pushed
the
rkrasiuk/fix-wiped-storage-prefix-set
branch
from
6a67f53
to
db0ff1e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For overlay root, we construct prefix set based on bundle state. When the storage gets wiped, the prefix set contains only the slots modified in the block. This means that if the storage trie for account already has intermediate nodes in the database that would not be updated during recomputation, they will be picked up by the storage root calculator and considered part of the trie.
Fix this behavior by introducing
allflag on the prefix set which invalidates all intermediate nodes.