feat: add support for xTokens pallet #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add tests for transferMultiassetWithFee
TarikGul
reviewed
Jul 29, 2023
TarikGul
reviewed
Jul 29, 2023
add weight vars as CreateWeightLimitOpts
…Tokens pallet exists updated foreignAssetMultiLocationExists to always query the current relay registry asset hub rather than the current origin chains state to account for non system chain queries added util function to create AssetHub api in order to query foreign assets pallet
temporarily remove asset hub assetId chain state queries
fix v2 to xcmv3weights conflicts
update asset-transfer-api-registry to 0.2.6 update Registry to include xcAssets
marshacb
changed the title
TarikGul
reviewed
Aug 16, 2023
src/types.ts
Outdated
| * Provided when creating limited txs, represents the allowed amount of computation time | ||
| * the tx can use | ||
| */ | ||
| refTime?: string; |
There was a problem hiding this comment.
Replace weightLimit: string with weightLimit: { refTime: string, proofSize: string }
TarikGul
reviewed
Aug 16, 2023
src/AssetsTransferApi.spec.ts
Outdated
| @@ -659,6 +659,8 @@ describe('AssetTransferAPI', () => { | |||
| xcmVersion: 3, | |||
| weightLimit: '100000', | |||
| isLimited: true, | |||
| refTime: '1000', | |||
There was a problem hiding this comment.
Note this should be updated with the Weightlimit change.
add checkParaAssets specs remove xcAssets BaseErrors from ParaToSystem xTokens
TarikGul
reviewed
Aug 18, 2023
| import { getChainIdBySpecName } from './getChainIdBySpecName'; | ||
|
|
||
| /** | ||
| * Returns the correct asset id for a valid AssetHub token symbol integer id |
There was a problem hiding this comment.
This comment is a bit confusing. I think the punctuation just needs to be fixed and it will be perfect.
TarikGul
reviewed
Aug 18, 2023
| _specName, | ||
| registry, | ||
| { |
There was a problem hiding this comment.
If this is an option should it be at the end of the args? And I thinkxcmVersion, and paysWithFeeDest can be added to it.
There was a problem hiding this comment.
good catch. adding those to the options
TarikGul
approved these changes
Aug 18, 2023
update checkXcmTxInputs params
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
closes: #221