Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Pull Shared Constants into Commons #522

Open
apopiak opened this issue Jul 5, 2021 · 2 comments
Open

Pull Shared Constants into Commons #522

apopiak opened this issue Jul 5, 2021 · 2 comments
Assignees
@NachoPal
Labels
T7-system_parachains This PR/Issue is related to System Parachains. U3-nice_to_have Issue is worth doing eventually.

Comments

@apopiak
Copy link
Contributor

apopiak commented Jul 5, 2021

PRs like #516 need to adjust several files to set constants for all Statemint chains. Let's pull these constants into the commons crate to make this a bit more DRY.
@apopiak apopiak added the T7-system_parachains This PR/Issue is related to System Parachains. label Jul 5, 2021
@apopiak
Copy link
Contributor Author

apopiak commented Oct 20, 2021

a candidate: #684 (comment)

@NachoPal NachoPal self-assigned this Nov 10, 2021
@gilescope
Copy link
Contributor

maybe we should combine this with simplifying the parameter types now that paritytech/substrate#10402 has landed.

@the-right-joyce the-right-joyce added U3-nice_to_have Issue is worth doing eventually. and removed P7-nicetohave labels Aug 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@NachoPal NachoPal

Labels
T7-system_parachains This PR/Issue is related to System Parachains. U3-nice_to_have Issue is worth doing eventually.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@gilescope @apopiak @NachoPal @hbulgarini @the-right-joyce