Replace parameter_types with ConstU32 &c. #10402

dharjeezy · 2021-12-02T00:14:39Z

Replace parameter types with Const types as described in this issue #10383

Polkadot address: 12ZNas89oEagaxLVNbpqmvfMxdrGrqN7gJKSpwthTUPZsrku

gui1117

some more to remove, but seems good otherwise

bin/node-template/pallets/template/src/mock.rs

frame/aura/src/mock.rs

frame/beefy-mmr/src/mock.rs

frame/bounties/src/tests.rs

frame/tips/src/tests.rs

bin/node-template/runtime/src/lib.rs

gui1117 · 2021-12-07T02:11:27Z

bin/node-template/runtime/src/lib.rs

 	type MaxReserves = ();
 	type ReserveIdentifier = [u8; 8];
 	/// The type for recording an account's balance.
 	type Balance = Balance;
 	/// The ubiquitous event type.
 	type Event = Event;
 	type DustRemoval = ();
-	type ExistentialDeposit = ExistentialDeposit;
+	type ExistentialDeposit = ConstU128<500>;
 	type AccountStore = System;
 	type WeightInfo = pallet_balances::weights::SubstrateWeight<Runtime>;
 }

 parameter_types! {
 	pub const TransactionByteFee: Balance = 1;


we could also remove this with a ConstU128 actually

still to do

bin/node/runtime/src/lib.rs

frame/assets/src/mock.rs

frame/babe/src/mock.rs

frame/system/benches/bench.rs

gui1117

there is still some miss, but LGTM

bkchr · 2021-12-11T15:45:21Z

Requires master merge

… dharjeezy/change-parameter-types � Conflicts: � bin/node-template/runtime/src/lib.rs � bin/node/runtime/src/lib.rs � frame/assets/src/mock.rs � frame/support/src/traits.rs

…/dharjeezy/substrate-1 into dharjeezy/change-parameter-types

dharjeezy · 2021-12-11T17:31:12Z

Requires master merge

Hello @bkchr I have merged master now

…lets

gui1117 · 2021-12-16T02:10:45Z

but I think we can have a follow up we remove more parameter_types:

paritytech-processbot · 2021-12-16T02:19:18Z

Merge cancelled due to error. Error: Head SHA changed from 1aca17d to c67bc24

gui1117 · 2021-12-16T02:21:51Z

bot merge

paritytech-processbot · 2021-12-16T02:21:59Z

Waiting for commit status.

dharjeezy · 2021-12-16T07:40:03Z

See you merged @thiolliere
No tip? 😑😕

gui1117 · 2021-12-16T07:45:54Z

sorry I'm not used to the tip system

gui1117 · 2021-12-16T07:45:59Z

/tip small

substrate-tip-bot · 2021-12-16T07:46:00Z

Please fix the following problems before calling the tip bot again:

You are not allowed to access the tip bot. Only ["shawntabrizi", "gavofyork", "rphmeier", "athei", "andresilva", "arkpar", "bkchr", "eskimor", "drahnr", "dvdplm", "robbepop", "cmichi", "tomaka", "pepyakin", "tomusdrw"] are allowed.

gui1117 · 2021-12-16T07:47:07Z

@shawntabrizi maybe can I have access to the tip bot or you could run it here ?

dharjeezy · 2021-12-16T17:45:45Z

@shawntabrizi maybe can I have access to the tip bot or you could run it here ?

You there? @shawntabrizi

shawntabrizi · 2021-12-16T23:11:22Z

/tip small

substrate-tip-bot · 2021-12-16T23:11:27Z

A small tip was successfully submitted for dharjeezy (12ZNas89oEagaxLVNbpqmvfMxdrGrqN7gJKSpwthTUPZsrku on polkadot).

https://polkadot.js.org/apps/#/treasury/tips

dharjeezy · 2021-12-16T23:15:08Z

/tip small

Thanks for the tip everyone.

* remove parameter types and use const type * remove parameter types and use const type * Delete { * Delete count, * refractor for beefy, benchmarking, child bounties, and collective pallets * refractor for pallet contracts * refractor for elections * refractor for more pallets * fix CI issues * fix CI issues * fix CI issues * fix CI issues * remove warning to fix CI issue * remove warning to fix CI issue refractor for pallet preimage * remove warning to fix CI issue refractor for pallet proxy * remove warning to fix CI issue refractor for pallet recovery refractor for pallet randomness-collective-flip * remove warning to fix CI issue refractor for pallet scored-pool refractor for pallet scheduler refractor for pallet session * remove warning to fix CI issue refractor for pallet society, support, system, timestamp, tips * remove warning to fix CI issue refractor for pallet transaction_payment, transaction_storage, treasury, uniques, utility * remove warning to fix CI issue * cargo +nightly fmt * CI fix * more param refractor on beefy-mmr * refractor for beefy * Update frame/babe/src/mock.rs * Update frame/babe/src/mock.rs * Update frame/bounties/src/tests.rs * Update frame/tips/src/tests.rs * Delete mock.rs * Update frame/examples/basic/src/tests.rs * Apply suggestions from code review * Update frame/im-online/src/mock.rs * Update frame/im-online/src/mock.rs * Update frame/offences/benchmarking/src/mock.rs * Update frame/session/benchmarking/src/mock.rs * Update frame/support/test/tests/pallet_compatibility.rs * Update frame/support/test/tests/pallet_compatibility_instance.rs * Update frame/treasury/src/tests.rs * Update test-utils/runtime/src/lib.rs * some cleanup * fmt * remove unused Co-authored-by: Damilare <dakinlose@teamapt.com> Co-authored-by: Guillaume Thiolliere <gui.thiolliere@gmail.com>

remove parameter types and use const type

949cf3a

dharjeezy requested review from adoerr, andresilva and kianenigma as code owners December 2, 2021 00:14

gui1117 reviewed Dec 3, 2021

View reviewed changes

shawntabrizi reviewed Dec 3, 2021

View reviewed changes

bin/node-template/runtime/src/lib.rs Outdated Show resolved Hide resolved

Damilare added 2 commits December 3, 2021 23:31

remove parameter types and use const type

e0a6de6

fix merge conflict

eb685a2

dharjeezy requested review from shawntabrizi and gui1117 December 3, 2021 23:10

gui1117 reviewed Dec 7, 2021

View reviewed changes

bin/node/runtime/src/lib.rs Show resolved Hide resolved

gui1117 reviewed Dec 7, 2021

View reviewed changes

frame/assets/src/mock.rs Outdated Show resolved Hide resolved

gui1117 reviewed Dec 7, 2021

View reviewed changes

frame/babe/src/mock.rs Outdated Show resolved Hide resolved

gui1117 reviewed Dec 7, 2021

View reviewed changes

frame/system/benches/bench.rs Outdated Show resolved Hide resolved

gui1117 added 2 commits December 7, 2021 11:21

Delete {

c65bd09

Delete count,

691c8a0

gui1117 approved these changes Dec 7, 2021

View reviewed changes

Damilare added 2 commits December 11, 2021 18:24

Merge branch 'master' of https://github.com/paritytech/substrate into…

367dfe1

… dharjeezy/change-parameter-types � Conflicts: � bin/node-template/runtime/src/lib.rs � bin/node/runtime/src/lib.rs � frame/assets/src/mock.rs � frame/support/src/traits.rs

Merge branch 'dharjeezy/change-parameter-types' of https://github.com…

a7ec5ed

…/dharjeezy/substrate-1 into dharjeezy/change-parameter-types

Damilare added 2 commits December 11, 2021 19:14

refractor for beefy, benchmarking, child bounties, and collective pal…

97c6827

…lets

refractor for pallet contracts

d4cb6cd

dharjeezy requested a review from athei as a code owner December 11, 2021 18:18

refractor for elections

79803af

gui1117 added A0-please_review Pull request needs code review. and removed A3-in_progress Pull request is in progress. No review needed at this stage. labels Dec 16, 2021

remove unused

c67bc24

paritytech-processbot bot merged commit 4db2f22 into paritytech:master Dec 16, 2021

KiChjang mentioned this pull request Dec 18, 2021

Replace parameter_types with ConstU32 &c. #10383

Closed

georgesdib mentioned this pull request Dec 31, 2021

Generate storage info for Pallet Staking #9864

Closed

gilescope mentioned this pull request Jan 7, 2022

Pull Shared Constants into Commons paritytech/cumulus#522

Open

bizzyvinci mentioned this pull request Apr 21, 2022

Replace simple parameter_types #11254

Merged

AurevoirXavier mentioned this pull request Sep 8, 2022

Simplify parameter_types darwinia-network/darwinia-common#1434

Closed

AurevoirXavier added a commit to darwinia-network/darwinia-common that referenced this pull request Sep 8, 2022

Companion of paritytech/substrate#10402 part.1

9122cd1

dharjeezy mentioned this pull request Oct 17, 2022

Member request polkadot-fellows/seeding#41

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Replace parameter_types with ConstU32 &c. #10402

Replace parameter_types with ConstU32 &c. #10402

dharjeezy commented Dec 2, 2021

gui1117 left a comment

gui1117 Dec 7, 2021

gui1117 Dec 16, 2021

gui1117 left a comment

bkchr commented Dec 11, 2021

dharjeezy commented Dec 11, 2021

gui1117 commented Dec 16, 2021 •

edited

Loading

paritytech-processbot bot commented Dec 16, 2021

gui1117 commented Dec 16, 2021

paritytech-processbot bot commented Dec 16, 2021

dharjeezy commented Dec 16, 2021

gui1117 commented Dec 16, 2021

gui1117 commented Dec 16, 2021

substrate-tip-bot bot commented Dec 16, 2021

gui1117 commented Dec 16, 2021 •

edited

Loading

dharjeezy commented Dec 16, 2021

shawntabrizi commented Dec 16, 2021

substrate-tip-bot bot commented Dec 16, 2021

dharjeezy commented Dec 16, 2021

Replace parameter_types with ConstU32 &c. #10402

Replace parameter_types with ConstU32 &c. #10402

Conversation

dharjeezy commented Dec 2, 2021

gui1117 left a comment

Choose a reason for hiding this comment

gui1117 Dec 7, 2021

Choose a reason for hiding this comment

gui1117 Dec 16, 2021

Choose a reason for hiding this comment

gui1117 left a comment

Choose a reason for hiding this comment

bkchr commented Dec 11, 2021

dharjeezy commented Dec 11, 2021

gui1117 commented Dec 16, 2021 • edited Loading

paritytech-processbot bot commented Dec 16, 2021

gui1117 commented Dec 16, 2021

paritytech-processbot bot commented Dec 16, 2021

dharjeezy commented Dec 16, 2021

gui1117 commented Dec 16, 2021

gui1117 commented Dec 16, 2021

substrate-tip-bot bot commented Dec 16, 2021

gui1117 commented Dec 16, 2021 • edited Loading

dharjeezy commented Dec 16, 2021

shawntabrizi commented Dec 16, 2021

substrate-tip-bot bot commented Dec 16, 2021

dharjeezy commented Dec 16, 2021

gui1117 commented Dec 16, 2021 •

edited

Loading

gui1117 commented Dec 16, 2021 •

edited

Loading