Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

companion for #13992 #2560

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

companion for #13992 #2560

wants to merge 3 commits into from

Conversation

niklasad1
Copy link
Member

No description provided.

@niklasad1 niklasad1 added A4-companion A PR that should be considered alongside another (usually more comprehensive and detailed) PR. B1-note_worthy Changes should be noted in the release notes C1-low PR touches the given topic and has a low impact on builders. T0-node This PR/Issue is related to the topic “node”. labels May 10, 2023
This was referenced May 10, 2023
Open
Open
@skunert
Copy link
Contributor

skunert commented May 11, 2023

Your companion in substrate will pass if you bump jsonrpsee-core here:

cumulus/client/relay-chain-interface/Cargo.toml

Line 20 in 35a443d

jsonrpsee-core = "0.16.2"

@niklasad1
Copy link
Member Author

niklasad1 commented May 11, 2023 •
edited
Loading

Thanks @skunert

Heads up we added https://docs.rs/jsonrpsee-ws-client/latest/jsonrpsee_ws_client/struct.WsClient.html#method.on_disconnect, I noticed the you have implemented some reconnect logic perhaps it could be simplified ^^

@skunert
Copy link
Contributor

skunert commented May 11, 2023

Thanks @skunert

Heads up we added https://docs.rs/jsonrpsee-ws-client/latest/jsonrpsee_ws_client/struct.WsClient.html#method.on_disconnect, I noticed the you have implemented some reconnect logic perhaps could be simplified ^^

Nice! I will come back to this.

@niklasad1
Copy link
Member Author

bot rebase

@paritytech-processbot
Copy link

Rebased

@paritytech-cicd-pr
Copy link

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable
Logs: https://gitlab.parity.io/parity/mirrors/cumulus/-/jobs/2820308

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sam0x17 sam0x17 sam0x17 approved these changes

@skunert skunert skunert approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
A4-companion A PR that should be considered alongside another (usually more comprehensive and detailed) PR. B1-note_worthy Changes should be noted in the release notes C1-low PR touches the given topic and has a low impact on builders. T0-node This PR/Issue is related to the topic “node”.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@niklasad1 @skunert @paritytech-cicd-pr @sam0x17