Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

AssetHubs - split weights for pallet_assets #2743

Merged
merged 25 commits into from
Jun 20, 2023

Conversation

bkontur
Copy link
Contributor

@bkontur bkontur commented Jun 15, 2023

Relates to: #2727

Closes: #2732

@paritytech-ci paritytech-ci requested review from a team June 15, 2023 10:41
@bkontur
Copy link
Contributor Author

bkontur commented Jun 15, 2023

bot bench $ pallet asset-hub-kusama assets pallet_assets
bot bench $ pallet asset-hub-westend assets pallet_assets
bot bench $ pallet asset-hub-polkadot assets pallet_assets

@command-bot
Copy link

command-bot bot commented Jun 15, 2023

@bkontur https://gitlab.parity.io/parity/mirrors/cumulus/-/jobs/2999032 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" pallet asset-hub-kusama assets pallet_assets. Check out https://gitlab.parity.io/parity/mirrors/cumulus/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 1-1affdb8f-28b9-4d70-a28f-84c5e0c4060f to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented Jun 15, 2023

@bkontur https://gitlab.parity.io/parity/mirrors/cumulus/-/jobs/2999033 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" pallet asset-hub-westend assets pallet_assets. Check out https://gitlab.parity.io/parity/mirrors/cumulus/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 2-69e37e68-1a84-4f32-9440-56987fa0ab95 to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented Jun 15, 2023

@bkontur https://gitlab.parity.io/parity/mirrors/cumulus/-/jobs/2999034 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" pallet asset-hub-polkadot assets pallet_assets. Check out https://gitlab.parity.io/parity/mirrors/cumulus/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 3-923e903f-8df4-4179-8758-2a1d86979e37 to cancel this command or bot cancel to cancel all commands in this pull request.

@bkontur bkontur added B0-silent Changes should not be mentioned in any release notes A0-please_review Pull request needs code review. C1-low PR touches the given topic and has a low impact on builders. labels Jun 15, 2023
@command-bot
Copy link

command-bot bot commented Jun 15, 2023

@bkontur Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" pallet asset-hub-kusama assets pallet_assets has finished. Result: https://gitlab.parity.io/parity/mirrors/cumulus/-/jobs/2999032 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/cumulus/-/jobs/2999032/artifacts/download.

@command-bot
Copy link

command-bot bot commented Jun 15, 2023

@bkontur Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" pallet asset-hub-westend assets pallet_assets has finished. Result: https://gitlab.parity.io/parity/mirrors/cumulus/-/jobs/2999033 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/cumulus/-/jobs/2999033/artifacts/download.

@command-bot
Copy link

command-bot bot commented Jun 15, 2023

@bkontur Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" pallet asset-hub-polkadot assets pallet_assets has finished. Result: https://gitlab.parity.io/parity/mirrors/cumulus/-/jobs/2999034 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/cumulus/-/jobs/2999034/artifacts/download.

@bkontur
Copy link
Contributor Author

bkontur commented Jun 15, 2023

bot bench $ pallet asset-hub-kusama assets pallet_assets
bot bench $ pallet asset-hub-westend assets pallet_assets
bot bench $ pallet asset-hub-polkadot assets pallet_assets

@command-bot
Copy link

command-bot bot commented Jun 15, 2023

@bkontur https://gitlab.parity.io/parity/mirrors/cumulus/-/jobs/3000147 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" pallet asset-hub-kusama assets pallet_assets. Check out https://gitlab.parity.io/parity/mirrors/cumulus/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 1-e8bc2fde-fc7f-45a5-bbfe-1e8736d350ec to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented Jun 15, 2023

@bkontur https://gitlab.parity.io/parity/mirrors/cumulus/-/jobs/3000152 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" pallet asset-hub-westend assets pallet_assets. Check out https://gitlab.parity.io/parity/mirrors/cumulus/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 2-8ab4d6ee-f393-475a-883b-c3ce1b033d0a to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented Jun 15, 2023

@bkontur https://gitlab.parity.io/parity/mirrors/cumulus/-/jobs/3000163 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" pallet asset-hub-polkadot assets pallet_assets. Check out https://gitlab.parity.io/parity/mirrors/cumulus/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 3-2f99fd5f-7eaa-4fa8-af85-e12d09f5ab65 to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented Jun 15, 2023

@bkontur Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" pallet asset-hub-kusama assets pallet_assets has finished. Result: https://gitlab.parity.io/parity/mirrors/cumulus/-/jobs/3000147 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/cumulus/-/jobs/3000147/artifacts/download.

@command-bot
Copy link

command-bot bot commented Jun 15, 2023

@bkontur Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" pallet asset-hub-westend assets pallet_assets has finished. Result: https://gitlab.parity.io/parity/mirrors/cumulus/-/jobs/3000152 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/cumulus/-/jobs/3000152/artifacts/download.

@command-bot
Copy link

command-bot bot commented Jun 15, 2023

@bkontur Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" pallet asset-hub-polkadot assets pallet_assets has finished. Result: https://gitlab.parity.io/parity/mirrors/cumulus/-/jobs/3000163 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/cumulus/-/jobs/3000163/artifacts/download.

@bkontur
Copy link
Contributor Author

bkontur commented Jun 15, 2023

bot rebase

@paritytech-processbot
Copy link

Rebased

@bkontur
Copy link
Contributor Author

bkontur commented Jun 15, 2023

bot bench $ pallet asset-hub-kusama assets pallet_assets
bot bench $ pallet asset-hub-westend assets pallet_assets
bot bench $ pallet asset-hub-polkadot assets pallet_assets

@command-bot
Copy link

command-bot bot commented Jun 15, 2023

@bkontur https://gitlab.parity.io/parity/mirrors/cumulus/-/jobs/3000208 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" pallet asset-hub-kusama assets pallet_assets. Check out https://gitlab.parity.io/parity/mirrors/cumulus/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 4-eb6913c9-0b76-4483-bc14-aa956b854869 to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented Jun 15, 2023

@bkontur https://gitlab.parity.io/parity/mirrors/cumulus/-/jobs/3000209 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" pallet asset-hub-westend assets pallet_assets. Check out https://gitlab.parity.io/parity/mirrors/cumulus/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 5-d28d3503-89a4-4f98-ae67-9d654ee81daa to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented Jun 15, 2023

@bkontur https://gitlab.parity.io/parity/mirrors/cumulus/-/jobs/3000210 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" pallet asset-hub-polkadot assets pallet_assets. Check out https://gitlab.parity.io/parity/mirrors/cumulus/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 6-e0bb9373-e65b-44ef-b5c6-aaece06c2fe2 to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented Jun 15, 2023

@bkontur Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" pallet asset-hub-kusama assets pallet_assets has finished. Result: https://gitlab.parity.io/parity/mirrors/cumulus/-/jobs/3000208 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/cumulus/-/jobs/3000208/artifacts/download.

@bkontur
Copy link
Contributor Author

bkontur commented Jun 19, 2023

bot bench $ pallet asset-hub-kusama assets pallet_assets
bot bench $ pallet asset-hub-westend assets pallet_assets

@command-bot
Copy link

command-bot bot commented Jun 19, 2023

@bkontur https://gitlab.parity.io/parity/mirrors/cumulus/-/jobs/3026578 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" pallet asset-hub-kusama assets pallet_assets. Check out https://gitlab.parity.io/parity/mirrors/cumulus/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 1-515ff825-2d42-4f9c-ad4a-00e8cbb6cce8 to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented Jun 19, 2023

@bkontur https://gitlab.parity.io/parity/mirrors/cumulus/-/jobs/3026589 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" pallet asset-hub-westend assets pallet_assets. Check out https://gitlab.parity.io/parity/mirrors/cumulus/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 2-5e30961e-e95b-4af2-976b-b751ed55a23b to cancel this command or bot cancel to cancel all commands in this pull request.

@bkontur
Copy link
Contributor Author

bkontur commented Jun 19, 2023

pallet_assets_assets

Please save us from the utterly awful naming.

pallet_assets_local and pallet_assets_remote would be acceptable.

@gavofyork

changed to pallet_assets_local.rs / pallet_assets_remote.rs

@bkontur bkontur requested a review from gavofyork June 19, 2023 20:21
@command-bot
Copy link

command-bot bot commented Jun 19, 2023

@bkontur Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" pallet asset-hub-kusama assets pallet_assets has finished. Result: https://gitlab.parity.io/parity/mirrors/cumulus/-/jobs/3026578 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/cumulus/-/jobs/3026578/artifacts/download.

@command-bot
Copy link

command-bot bot commented Jun 19, 2023

@bkontur Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" pallet asset-hub-westend assets pallet_assets has finished. Result: https://gitlab.parity.io/parity/mirrors/cumulus/-/jobs/3026589 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/cumulus/-/jobs/3026589/artifacts/download.

@gavofyork
Copy link
Member

pallet_assets_assets

Please save us from the utterly awful naming.
pallet_assets_local and pallet_assets_remote would be acceptable.

@gavofyork

changed to pallet_assets_local.rs / pallet_assets_remote.rs

Actually, pallet_assets_foreign would work better...

@bkontur
Copy link
Contributor Author

bkontur commented Jun 20, 2023

bot bench $ pallet asset-hub-kusama assets pallet_assets
bot bench $ pallet asset-hub-westend assets pallet_assets
bot bench $ pallet asset-hub-polkadot assets pallet_assets

@command-bot
Copy link

command-bot bot commented Jun 20, 2023

@bkontur https://gitlab.parity.io/parity/mirrors/cumulus/-/jobs/3032047 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" pallet asset-hub-kusama assets pallet_assets. Check out https://gitlab.parity.io/parity/mirrors/cumulus/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 7-f2f8139e-1bb2-45d8-b2f6-6123ef7182f0 to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented Jun 20, 2023

@bkontur https://gitlab.parity.io/parity/mirrors/cumulus/-/jobs/3032048 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" pallet asset-hub-westend assets pallet_assets. Check out https://gitlab.parity.io/parity/mirrors/cumulus/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 8-a50258f6-6dbb-4b0c-9557-4107cfb96dde to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented Jun 20, 2023

@bkontur https://gitlab.parity.io/parity/mirrors/cumulus/-/jobs/3032049 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" pallet asset-hub-polkadot assets pallet_assets. Check out https://gitlab.parity.io/parity/mirrors/cumulus/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 9-2aba4af8-3c7e-4c5c-bc8d-5502fa3e0f3d to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented Jun 20, 2023

@bkontur Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" pallet asset-hub-kusama assets pallet_assets has finished. Result: https://gitlab.parity.io/parity/mirrors/cumulus/-/jobs/3032047 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/cumulus/-/jobs/3032047/artifacts/download.

@command-bot
Copy link

command-bot bot commented Jun 20, 2023

@bkontur Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" pallet asset-hub-westend assets pallet_assets has finished. Result: https://gitlab.parity.io/parity/mirrors/cumulus/-/jobs/3032048 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/cumulus/-/jobs/3032048/artifacts/download.

@command-bot
Copy link

command-bot bot commented Jun 20, 2023

@bkontur Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" pallet asset-hub-polkadot assets pallet_assets has finished. Result: https://gitlab.parity.io/parity/mirrors/cumulus/-/jobs/3032049 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/cumulus/-/jobs/3032049/artifacts/download.

@bkontur
Copy link
Contributor Author

bkontur commented Jun 20, 2023

bot merge

@paritytech-processbot
Copy link

Waiting for commit status.

@paritytech-processbot paritytech-processbot bot merged commit 1fcfaed into master Jun 20, 2023
@paritytech-processbot paritytech-processbot bot deleted the bko-fix-benchmarks branch June 20, 2023 15:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AssetHubs - split weights for pallet_assets for different instances
7 participants