Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dedup_len trait #532

Closed
wants to merge 6 commits into from
Closed

Add dedup_len trait #532

wants to merge 6 commits into from

Conversation

0xmovses
Copy link

@0xmovses 0xmovses commented Oct 18, 2023

This is a fix for paritytech/polkadot-sdk#126

@0xmovses 0xmovses marked this pull request as draft October 18, 2023 12:10
@0xmovses 0xmovses changed the title 0xmovses dedup len Add dedup_len trait Oct 18, 2023
@bkchr
Copy link
Member

bkchr commented Oct 18, 2023

Please revert the FMT commit.

@ggwpez
Copy link
Member

ggwpez commented Oct 18, 2023

Wait... this adds a DecodeDedupLength trait for BTreeSet? I dont think thats possible. The advantage of the DecodeLen is that is does not have to decode everything, but only a Compact<u32>.
What i meant in the other issue to just remove the impl DecodeLen for BTreeSet and replace it with a DecodeNonDedupLen or so.
cc @bkchr

@0xmovses
Copy link
Author

Yeah that's clearer now, let me update this.

@0xmovses
Copy link
Author

0xmovses commented Oct 18, 2023

I don't think we need to add this here anymore, as we are just adding a more descriptive trait in polkadot-sdk, closing this.

@0xmovses 0xmovses closed this Oct 18, 2023
@bkchr bkchr deleted the 0xmovses-dedup-len branch October 18, 2023 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants