Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add collectives-westend and glutton-westend runtimes #2024

Merged
merged 108 commits into from
Nov 15, 2023

Conversation

seadanda
Copy link
Contributor

@seadanda seadanda commented Oct 25, 2023

Add collectives and glutton parachain westend runtimes to prepare for #1737.

The removal of system parachain native runtimes #1737 is blocked until chainspecs and runtime APIs can be dealt with cleanly (merge of #1256 and follow up PRs).

In the meantime, these additions are ready to be merged to master, so I have separated them out into this PR.

Also marked bridge-hub-westend as unimplemented in line with this issue.

TODO

  • add to command-bot benchmarks
  • add to command-bot-scripts benchmarks
  • generate weights

Westend equivalents to be added later
Replace for collectives and glutton parachains for development
This reverts commit b1de92d.
Copy link
Contributor

@bkontur bkontur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, just left a few nits

Copy link
Contributor

@liamaharon liamaharon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appreciate if you could add migration CI for collectives westend to .gitlab/pipeline/check.yml in this PR, see #2336 for reference.

Should be something like:

# Check runtime migrations for Parity managed collectives chains
check-runtime-migration-collectives-westend:
  stage: check
  extends:
    - .docker-env
    - .test-pr-refs
    - .check-runtime-migration
  variables:
    NETWORK: "collectives-westend"
    PACKAGE: "collectives-westend-runtime"
    WASM: "collectives_westend_runtime.compact.compressed.wasm"
    URI: "wss://westend-collectives-rpc.polkadot.io:443"

@paritytech-cicd-pr
Copy link

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: cargo-clippy
Logs: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4341368

@seadanda seadanda enabled auto-merge (squash) November 15, 2023 14:21
@seadanda seadanda merged commit 0226b55 into master Nov 15, 2023
112 of 116 checks passed
@seadanda seadanda deleted the donal-prepare-sp-native-runtime-removal branch November 15, 2023 15:01
ordian added a commit that referenced this pull request Nov 22, 2023
* tsv-disabling: (46 commits)
  frame-system: Add `last_runtime_upgrade_spec_version` (#2351)
  [testnet] Remove Wococo stuff from BridgeHubRococo/AssetHubRococo (#2300)
  xcm: SovereignPaidRemoteExporter: remove unused RefundSurplus instruction (#2312)
  Add `collectives-westend` and `glutton-westend` runtimes (#2024)
  Identity Deposits Relay to Parachain Migration (#1814)
  [CI] Prepare CI for Merge Queues (#2308)
  Unify `ChainSync` actions under one enum (follow-up) (#2317)
  pallet-xcm: use XcmTeleportFilter for teleported fees in reserve transfers (#2322)
  Contracts expose pallet-xcm (#1248)
  add NodeFeatures field to HostConfiguration and runtime API (#2177)
  statement-distribution: support inactive local validator in grid (#1571)
  change prepare worker to use fork instead of threads (#1685)
  chainHead/tests: Fix clippy (#2325)
  Contracts: Bump contracts rococo (#2286)
  Add simple collator election mechanism (#1340)
  chainHead: Remove `chainHead_genesis` method (#2296)
  chainHead: Support multiple hashes for `chainHead_unpin` method (#2295)
  Add environment to claim workflow (#2318)
  PVF: fix detection of unshare-and-change-root security capability (#2304)
  xcm-emulator: add Rococo<>Westend bridge and add tests for assets transfers over the bridge (#2251)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T14-system_parachains This PR/Issue is related to system parachains.
Projects
None yet
Development

Successfully merging this pull request may close these issues.