Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pallet-xcm: fix test benchmarks #2679

Merged
merged 1 commit into from
Dec 11, 2023

Conversation

acatangiu
Copy link
Contributor

For some reason original PR passed CI - when it shouldn't have. Fix pallet-xcm test benchmarks.

@acatangiu acatangiu added the R0-silent Changes should not be mentioned in any release notes label Dec 11, 2023
@acatangiu acatangiu self-assigned this Dec 11, 2023
@acatangiu acatangiu requested a review from a team as a code owner December 11, 2023 09:18
@acatangiu acatangiu enabled auto-merge (squash) December 11, 2023 09:23
@acatangiu acatangiu merged commit 6cedb0c into paritytech:master Dec 11, 2023
119 of 122 checks passed
@acatangiu acatangiu deleted the fix-benchmarks branch December 11, 2023 13:46
bkontur pushed a commit that referenced this pull request Feb 2, 2024
For some reason original PR passed CI - when it shouldn't have. Fix
`pallet-xcm` test benchmarks.
franciscoaguirre pushed a commit that referenced this pull request Feb 2, 2024
For some reason original PR passed CI - when it shouldn't have. Fix
`pallet-xcm` test benchmarks.
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Mar 26, 2024
* Adding gitspiegel-trigger workflow (paritytech#2661)

Using a workflow to trigger mirroring instead of a webhook allows us to reuse "Approving workflow runs from public forks" GitHub feature to somewhat protect us from malicious PRs

* Fixing gitspiegel trigger workflow (paritytech#2679)

The first attept to use a workflow to protect GitLab CI from untrusted contributors failed, because GitHub doesn't pass secrets to workflows for PRs that originate from forks. 
 
This uses a different approach: instead of triggerring gitspiegel API directly from the workflow, we're just spawning an empty workflow with a specific path, and gitspiegel listens for `workflow_run` event to start mirroring.  

The idea is the same: for the first-time contributors, running workflows would require manual aciton and that would block mirroring. But this time, we don't need any secrets to make it work.

---------

Co-authored-by: Yuri Volkov <0@mcornholio.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
R0-silent Changes should not be mentioned in any release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants