Add FungibleAdapter #2684
Add FungibleAdapter #2684
Conversation
|
bot fmt |
|
@franciscoaguirre https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4688963 was started for your command Comment |
|
@franciscoaguirre Command |
|
bot fmt |
|
@franciscoaguirre https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4695787 was started for your command Comment |
|
@franciscoaguirre Command |
|
The CI pipeline was cancelled due to failure one of the required jobs. |
franciscoaguirre
force-pushed
the
cis-fungible-adapter
branch
from
6c739a9
to
6cfcce6
Compare
|
bot fmt |
|
@franciscoaguirre https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4716123 was started for your command Comment |
|
@franciscoaguirre Command |
Merge queue setting changed
| @@ -16,6 +16,8 @@ | |||
|
|
|||
| //! Adapters to work with `frame_support::traits::Currency` through XCM. | |||
|
|
|||
| #![allow(deprecated)] | |||
There was a problem hiding this comment.
nit: seems that it's only a couple of places in code where we'd need #[allow(deprecated)], so I'd prefer individual annotations instead of this , but it's fine either way.
|
This pull request has been mentioned on Polkadot Forum. There might be relevant details there: https://forum.polkadot.network/t/polkadot-release-analysis-v1-6-0/5855/1 |
In the move from the old `Currency` traits to the new `fungible/s` family of traits, we already had the `FungiblesAdapter` and `NonFungiblesAdapter` for multiple fungible and non fungible assets respectively. However, for handling only one fungible asset, we were missing a `FungibleAdapter`, and so used the old `CurrencyAdapter` instead. This PR aims to fill in that gap, and provide the new adapter for more updated examples. I marked the old `CurrencyAdapter` as deprecated as part of this PR, and I'll change it to the new `FungibleAdapter` in a following PR. The two stages are separated so as to not bloat this PR with some name fixes in tests. --------- Co-authored-by: command-bot <>
In the move from the old
Currencytraits to the newfungible/sfamily of traits, we already had theFungiblesAdapterandNonFungiblesAdapterfor multiple fungible and non fungible assets respectively. However, for handling only one fungible asset, we were missing aFungibleAdapter, and so used the oldCurrencyAdapterinstead. This PR aims to fill in that gap, and provide the new adapter for more updated examples.I marked the old
CurrencyAdapteras deprecated as part of this PR, and I'll change it to the newFungibleAdapterin a following PR.The two stages are separated so as to not bloat this PR with some name fixes in tests.