Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature gate do_task in frame_system #2707

Merged
merged 6 commits into from
Dec 15, 2023
Merged

Feature gate do_task in frame_system #2707

merged 6 commits into from
Dec 15, 2023

Conversation

gupnik
Copy link
Contributor

@gupnik gupnik commented Dec 14, 2023

#1343 introduced Tasks API. This one moves do_task call in frame_system under the experimental flag, till the previous one is audited.

@gupnik gupnik added R0-silent Changes should not be mentioned in any release notes T1-FRAME This PR/Issue is related to core FRAME, the framework. labels Dec 14, 2023
@gupnik gupnik requested review from a team December 14, 2023 06:00
@gupnik
Copy link
Contributor Author

gupnik commented Dec 14, 2023

bot fmt

@command-bot
Copy link

command-bot bot commented Dec 14, 2023 •
edited
Loading

@gupnik https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4721996 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 4-2beb2d4a-c43a-4a79-89ac-823c61238861 to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented Dec 14, 2023

@gupnik Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4721996 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4721996/artifacts/download.

@paritytech-cicd-pr
Copy link

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: cargo-clippy
Logs: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4722557

@gupnik gupnik merged commit 11edbaf into master Dec 15, 2023
118 of 119 checks passed
@gupnik gupnik deleted the gupnik/tasks-feature-gate branch December 15, 2023 05:47
@github-actions github-actions bot mentioned this pull request Feb 19, 2024
Closed
@github-actions github-actions bot mentioned this pull request Mar 13, 2024
Closed
bgallois pushed a commit to duniter/duniter-polkadot-sdk that referenced this pull request Mar 25, 2024
@codekitz
Feature gate do_task in frame_system (paritytech#2707)
42dba75 
paritytech#1343 introduced Tasks
API. This one moves `do_task` call in frame_system under the
experimental flag, till the previous one is audited.

---------

Co-authored-by: command-bot <>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gpestana gpestana gpestana approved these changes

@bkchr bkchr bkchr approved these changes

@ggwpez ggwpez ggwpez approved these changes

Assignees
No one assigned
Labels
R0-silent Changes should not be mentioned in any release notes T1-FRAME This PR/Issue is related to core FRAME, the framework.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@gupnik @paritytech-cicd-pr @gpestana @bkchr @ggwpez @codekitz