Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update translate to use defensive! #2985

Merged
merged 15 commits into from
Jan 19, 2024
Merged

Update translate to use defensive! #2985

merged 15 commits into from
Jan 19, 2024

Conversation

liamaharon
Copy link
Contributor

Closes #1323

cc @xlc

@liamaharon liamaharon added the T0-node This PR/Issue is related to the topic “node”. label Jan 18, 2024
@liamaharon liamaharon requested review from a team January 18, 2024 13:42
liamaharon and others added 3 commits January 19, 2024 02:33
@liamaharon @joepetrowski
Update substrate/frame/support/src/storage/generator/map.rs
03ed3a3 
Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com>
@liamaharon @joepetrowski
Update substrate/frame/support/src/storage/types/map.rs
66442c0 
Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com>
@liamaharon @joepetrowski
Update substrate/frame/support/src/storage/generator/map.rs
f3c9d1c 
Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com>
@paritytech-review-bot paritytech-review-bot bot requested a review from a team January 18, 2024 15:34
bkchr
bkchr approved these changes Jan 18, 2024
View reviewed changes
substrate/frame/support/src/storage/generator/map.rs Outdated Show resolved Hide resolved
substrate/frame/support/src/storage/generator/map.rs Outdated Show resolved Hide resolved
liamaharon and others added 2 commits January 19, 2024 14:50
@liamaharon @bkchr
Update substrate/frame/support/src/storage/generator/map.rs
576fef5 
Co-authored-by: Bastian Köcher <git@kchr.de>
@liamaharon @bkchr
Update substrate/frame/support/src/storage/generator/map.rs
7068f79 
Co-authored-by: Bastian Köcher <git@kchr.de>
@paritytech-cicd-pr
Copy link

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable-int
Logs: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4963511

@liamaharon liamaharon added this pull request to the merge queue Jan 19, 2024
Merged via the queue into master with commit 697c2c3 Jan 19, 2024
122 of 124 checks passed
@liamaharon liamaharon deleted the liam-translate-defensive-fail branch January 19, 2024 13:19
@github-actions github-actions bot mentioned this pull request Mar 13, 2024
Closed
bgallois pushed a commit to duniter/duniter-polkadot-sdk that referenced this pull request Mar 25, 2024
@liamaharon @joepetrowski @bkchr
Update translate to use defensive! (paritytech#2985)
3dc890c 
Closes paritytech#1323 

cc @xlc

---------

Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com>
Co-authored-by: Bastian Köcher <git@kchr.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muharem muharem muharem approved these changes

@joepetrowski joepetrowski joepetrowski left review comments

@kianenigma kianenigma kianenigma approved these changes

@bkchr bkchr bkchr approved these changes

@ggwpez ggwpez ggwpez approved these changes

Assignees
No one assigned
Labels
T0-node This PR/Issue is related to the topic “node”.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update translate to use defensive!
7 participants
@liamaharon @paritytech-cicd-pr @kianenigma @bkchr @muharem @ggwpez @joepetrowski