-
Notifications
You must be signed in to change notification settings - Fork 666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cumulus] Feature gates for rococo/westend related stuff in the parachains-common
#3041
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
Co-authored-by: Adrian Catangiu <adrian@parity.io>
The CI pipeline was cancelled due to failure one of the required jobs. |
The CI pipeline was cancelled due to failure one of the required jobs. |
The CI pipeline was cancelled due to failure one of the required jobs. |
The stuff in the crate that is only for the fellowship runtimes, should be put into a crate in the fellowship repo. Fellowship should really only depend on pallets on common structs, nothing that is specialized for any kind of chain. |
Actually, I didn't check other stuff inside (just that rococo/westend stuff). Afaik, |
This PR avoids automatically pulling rococo/westend runtime constants into the runtime by default. Usually, we have testnet runtimes dedicated to rococo or westend, and therefore, we don't need both dependencies. Additionally, it prevents pulling rococo/westend-related items into the
polkadot-fellows
repo, as seen in the Cargo.lock here and here.