Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error on duplicated crates #3082

Merged
merged 4 commits into from
Jan 29, 2024
Merged

Error on duplicated crates #3082

merged 4 commits into from
Jan 29, 2024

Conversation

ggwpez
Copy link
Member

@ggwpez ggwpez commented Jan 26, 2024

#2970 accidentally added a crate twice to the workspace. Now extending the workspace check to explicitly error then.

I think the check should also be required now.

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez ggwpez added the R0-silent Changes should not be mentioned in any release notes label Jan 26, 2024
@ggwpez ggwpez requested review from a team as code owners January 26, 2024 12:33
Copy link
Member

@bkchr bkchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 🚀

@ggwpez ggwpez added this pull request to the merge queue Jan 26, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 26, 2024
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@bkchr bkchr added this pull request to the merge queue Jan 29, 2024
Merged via the queue into master with commit 0291658 Jan 29, 2024
122 checks passed
@bkchr bkchr deleted the oty-explicit-duplicate-check branch January 29, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
R0-silent Changes should not be mentioned in any release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants