Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add limits to XCMv4 #3114

Merged
merged 7 commits into from
Jan 31, 2024
Merged

Add limits to XCMv4 #3114

merged 7 commits into from
Jan 31, 2024

Conversation

franciscoaguirre
Copy link
Contributor

@franciscoaguirre franciscoaguirre commented Jan 29, 2024 •
edited
Loading

Some more work regarding XCMv4. Two limits from v3 were not transferred over, those are:

  • The instructions limit
  • The number of assets limit
    Both of these are now in v4.

For some reason AssetInstance increased in size, don't know why CI didn't catch that before.

@franciscoaguirre franciscoaguirre requested a review from a team as a code owner January 29, 2024 15:58
@franciscoaguirre franciscoaguirre added R0-silent Changes should not be mentioned in any release notes T6-XCM This PR/Issue is related to XCM. labels Jan 29, 2024
@franciscoaguirre franciscoaguirre changed the title Add instructions limit to v4 Add limits to v4 Jan 29, 2024
@franciscoaguirre franciscoaguirre changed the title Add limits to v4 Add limits to XCMv4 Jan 29, 2024
bkchr
bkchr reviewed Jan 30, 2024
View reviewed changes
polkadot/xcm/src/v4/mod.rs Outdated Show resolved Hide resolved
@franciscoaguirre
Copy link
Contributor Author

bot fmt

@command-bot
Copy link

command-bot bot commented Jan 30, 2024 •
edited
Loading

@franciscoaguirre https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5069449 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 1-7f47dad8-199b-475d-af6a-2605a5f829ad to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented Jan 30, 2024

@franciscoaguirre Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5069449 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5069449/artifacts/download.

@franciscoaguirre franciscoaguirre added this pull request to the merge queue Jan 31, 2024
Merged via the queue into master with commit cc4805b Jan 31, 2024
122 checks passed
@franciscoaguirre franciscoaguirre deleted the enforce-max-instructions-in-v4 branch January 31, 2024 03:42
@github-actions github-actions bot mentioned this pull request Mar 13, 2024
Closed
@jiguantong jiguantong mentioned this pull request Jun 21, 2024
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bkchr bkchr bkchr left review comments

@KiChjang KiChjang KiChjang approved these changes

@acatangiu acatangiu acatangiu approved these changes

Assignees
No one assigned
Labels
R0-silent Changes should not be mentioned in any release notes T6-XCM This PR/Issue is related to XCM.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@franciscoaguirre @KiChjang @bkchr @acatangiu