[cumulus] parachains-common testnet constants cleaning
#3134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkontur
added
R0-silent
NachoPal
approved these changes
Jan 30, 2024
cumulus/parachains/runtimes/collectives/collectives-westend/src/fellowship/mod.rs
Outdated
Show resolved
Hide resolved
cumulus/parachains/runtimes/collectives/collectives-westend/src/fellowship/mod.rs
Outdated
Show resolved
Hide resolved
NachoPal
approved these changes
Jan 30, 2024
cumulus/parachains/runtimes/assets/asset-hub-rococo/src/xcm_config.rs
Outdated
Show resolved
Hide resolved
cumulus/parachains/runtimes/bridge-hubs/bridge-hub-rococo/src/lib.rs
Outdated
Show resolved
Hide resolved
georgepisaltu
approved these changes
Jan 30, 2024
Co-authored-by: georgepisaltu <george.pisaltu@parity.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
parachains-commoncontains a lots of constants and type definitions which are used forpolkadot-sdk's testnet runtimes and also forpolkadot-fellows's production SP runtimes. This PR cleansparachains-commonmodule to contain only common and generic functionality.Testnet-specific constants have been moved to the separate module dedicated just for testnets:
polkadot-sdk/cumulus/parachains/runtimes/constants/Part of: #3054