Testnet HostConfiguration migration (v11 to v12) #3503
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
sandreim
added
R0-silent
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
alexggh
reviewed
Feb 28, 2024
alindima
reviewed
Feb 28, 2024
| type V11HostConfiguration<BlockNumber> = configuration::HostConfiguration<BlockNumber>; | ||
|
|
||
| #[derive(Clone, Encode, PartialEq, Decode, Debug)] | ||
| pub struct V11HostConfiguration<BlockNumber> { |
There was a problem hiding this comment.
if nothing changed between v11 and v12, can we not simply do pub type V11HostConfiguration = V12HostConfiguration?
There was a problem hiding this comment.
Yes, that is what I've done initially but decided to make it a different struct to avoid any missuses as we have many unreleased migrations and another one not merged here: #3181
tdimitrov
approved these changes
Feb 28, 2024
|
Superseded by: polkadot-fellows/runtimes#205 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one enables feature bit 1 (Elastic scaling MVP) but doesn't alter the structure.
Once the migration is done, upgraded nodes can include
CoreIndexin backed candidates that are passed to the parachains inherent. Runtime already supports this injectedCoreIndex. See #3231 and #3229