-
Notifications
You must be signed in to change notification settings - Fork 666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements in minimal template #4119
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great start. I think last step you should run this, and see what details you need to provide to the user about how to run etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regarding running the node:
- The block time being configurable
- Fixed transaction fees
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
… into gupnik/templates
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
My preference would be to move most of it to rustdoc and keep readme as a light intro. |
Is a correct comment in general. I foresee that a pallet can expose optionally, at most 3 configs:
And anything more can live in independent crate, possibly even outside I've also raised that a team (eg. OZ) can instead of building a full runtime with 10 pallets, simply provide a set of defaults for those 10 pallets.
Indeed, any default configs added to A downstream team can always opt out of using Possibly, we can even provide a default type that does nothing and raises a |
@liamaharon @franciscoaguirre @ggwpez Could you take a look at this again please? |
@@ -198,9 +198,9 @@ pub fn expand_tt_default_parts(def: &mut Def) -> proc_macro2::TokenStream { | |||
macro_rules! #default_parts_unique_id_v2 { | |||
{ | |||
$caller:tt | |||
frame_support = [{ $($frame_support:ident)::* }] | |||
your_tt_return = [{ $my_tt_return:path }] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I actually had the same issue on the polkadot-sdk umbrella crate and ended up using ::tt *
since path seems to also not be enough.
This PR makes a few improvements in the docs for the minimal template. --------- Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
This PR makes a few improvements in the docs for the minimal template. --------- Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
This PR makes a few improvements in the docs for the minimal template.