wasm-builder: Make it easier to build a WASM binary #4177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Basically combines all the recommended calls into one `build_using_defaults()` call or `init_with_defaults()` when there are some custom changes required.
koute
approved these changes
Apr 17, 2024
dmitry-markin
approved these changes
Apr 17, 2024
lexnv
approved these changes
Apr 17, 2024
| /// .import_memory() | ||
| /// .export_heap_base() | ||
| /// ``` | ||
| pub fn init_with_defaults() -> Self { |
There was a problem hiding this comment.
maybe just default?
michalkucharczyk
approved these changes
Apr 17, 2024
skunert
approved these changes
Apr 22, 2024
bkchr
added a commit
that referenced
this pull request
May 22, 2024
Basically combines all the recommended calls into one `build_using_defaults()` call or `init_with_defaults()` when there are some custom changes required.
bkchr
added a commit
that referenced
this pull request
May 22, 2024
Basically combines all the recommended calls into one `build_using_defaults()` call or `init_with_defaults()` when there are some custom changes required.
bkchr
added a commit
that referenced
this pull request
May 22, 2024
Basically combines all the recommended calls into one `build_using_defaults()` call or `init_with_defaults()` when there are some custom changes required.
bkchr
added a commit
that referenced
this pull request
May 23, 2024
Basically combines all the recommended calls into one `build_using_defaults()` call or `init_with_defaults()` when there are some custom changes required.
bkchr
added a commit
that referenced
this pull request
May 24, 2024
Basically combines all the recommended calls into one `build_using_defaults()` call or `init_with_defaults()` when there are some custom changes required.
bkchr
added a commit
that referenced
this pull request
May 24, 2024
Basically combines all the recommended calls into one `build_using_defaults()` call or `init_with_defaults()` when there are some custom changes required.
bkchr
added a commit
that referenced
this pull request
May 24, 2024
Basically combines all the recommended calls into one `build_using_defaults()` call or `init_with_defaults()` when there are some custom changes required.
bkchr
added a commit
that referenced
this pull request
May 24, 2024
Basically combines all the recommended calls into one `build_using_defaults()` call or `init_with_defaults()` when there are some custom changes required.
bkchr
added a commit
that referenced
this pull request
May 25, 2024
Basically combines all the recommended calls into one `build_using_defaults()` call or `init_with_defaults()` when there are some custom changes required.
bkchr
added a commit
that referenced
this pull request
May 25, 2024
Basically combines all the recommended calls into one `build_using_defaults()` call or `init_with_defaults()` when there are some custom changes required.
This was referenced Jun 5, 2024
This was referenced Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically combines all the recommended calls into one
build_using_defaults()call orinit_with_defaults()when there are some custom changes required.