Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

polkadot-parachain-bin: small cosmetics and improvements #4666

Merged
merged 9 commits into from
Jun 14, 2024

Commits on Jun 11, 2024

  1. Remove unused code

    serban300 committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    2dd7b91 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c30df86 View commit details
    Browse the repository at this point in the history
  3. Add convenience traits

    serban300 committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    493c1f1 View commit details
    Browse the repository at this point in the history
  4. Add Aura API check

    serban300 committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    c1d213c View commit details
    Browse the repository at this point in the history
  5. RelayChainCli improvements

    - Parse the `RelayChainCli` before starting the runner. This is helpful
      in case of executing `polkadot-parachain ... -- --help` or if the
      relay chain command is malformed
    - Set `no_binary_name(true)`
    - Use the same `base_path` as the parachain
      This will lead to using paths like for example:
      - /tmp/substratexaqpXv/chains/bridge-hub-kusama
      - /tmp/substratexaqpXv/chains/kusama
      instead of:
      - /tmp/substratexaqpXv/chains/bridge-hub-kusama
      - /tmp/substratexaqpXv/polkadot/chains/kusama
    serban300 committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    1d88271 View commit details
    Browse the repository at this point in the history
  6. Use the network backend from the parachain config

    For consistency. For example `start_node()` uses
    `FullNetworkConfiguration::<_, _, Net>::new(&parachain_config.network)`
    serban300 committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    6bfdebd View commit details
    Browse the repository at this point in the history

Commits on Jun 12, 2024

  1. Fix umbrella crate

    serban300 committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    f4e415d View commit details
    Browse the repository at this point in the history
  2. Revert base_path change

    serban300 committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    597067f View commit details
    Browse the repository at this point in the history
  3. Remove polkadot-parachains-common crate

    And move logic to polakdot-parachain
    serban300 committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    b517d76 View commit details
    Browse the repository at this point in the history