Fix occupied core handling #4691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandreim
reviewed
Jun 4, 2024
eskimor
added
the
T8-polkadot
alindima
approved these changes
Jun 7, 2024
| queue: Peekable<btree_map::IntoIter<CoreIndex, VecDeque<E>>>, | ||
| } | ||
|
|
||
| impl<E> Iterator for ClaimQueueIterator<E> { |
There was a problem hiding this comment.
nit: IMHO it would have been easier to comprehend and code if instead of this custom iterator we'd just loop over the availability cores and try fetching the claimqueue for that core (in fn eligible_paras). still, this iterator has the slight advantage that when zipped with the av-cores, it'll stop at the end of the claim queue and not go further. feel free to ignore
There was a problem hiding this comment.
Also it allows for returning an iterator, otherwise you would return a closure with a reference that won't live long enough.
Co-authored-by: Andrei Sandu <54316454+sandreim@users.noreply.github.com>
ordian
added a commit
that referenced
this pull request
Jun 13, 2024
* master: (29 commits) Append overlay optimization. (#1223) finalization: Skip tree route calculation if no forks present (#4721) Remove unncessary call remove_from_peers_set (#4742) add pov-recovery unit tests and support for elastic scaling (#4733) approval-voting: Add no shows debug information (#4726) Revamp the Readme of the parachain template (#4713) Update README.md to move the PSVM link under a "Tooling" section under the "Releases" section (#4734) frame/proc-macro: Refactor code for better readability (#4712) Contracts: update wasmi to 0.32 (#3679) Backport style changes from P<>K bridge to R<>W bridge (#4732) New reference doc for Custom RPC V2 (#4654) Frame Pallets: Clean a lot of test setups (#4642) Fix occupied core handling (#4691) statement-distribution: Fix false warning (#4727) Update the README to include a link to the Polkadot SDK Version Manager (#4718) Cleanup PVF artifact by cache limit and stale time (#4662) Update link to a latest polkadot release (#4711) [CI] Delete cargo-deny config (#4677) fix build on MacOS: bump secp256k1 and secp256k1-sys to patched versions (#4709) Unify dependency aliases (#4633) ...
TarekkMA
pushed a commit
to moonbeam-foundation/polkadot-sdk
that referenced
this pull request
Aug 2, 2024
Co-authored-by: eskimor <eskimor@no-such-url.com> Co-authored-by: Andrei Sandu <54316454+sandreim@users.noreply.github.com>
This was referenced Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.