This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Companion PR for adding max notification sizes #2287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomaka
added
A0-please_review
tomaka
commented
Jan 18, 2021
| @@ -36,9 +36,15 @@ impl PeerSet { | |||
| /// network service. | |||
| pub fn get_info(self) -> NonDefaultSetConfig { | |||
| let protocol = self.into_protocol_name(); | |||
| let max_notification_size = match self { | |||
| PeerSet::Validation = 1024 * 1024, | |||
There was a problem hiding this comment.
I went for 1MiB because pragmatically speaking that's the current limit, but it could be lower.
ordian
reviewed
Jan 18, 2021
ordian
approved these changes
Jan 18, 2021
ordian
reviewed
Jan 18, 2021
rphmeier
reviewed
Jan 18, 2021
| @@ -36,9 +36,17 @@ impl PeerSet { | |||
| /// network service. | |||
| pub fn get_info(self) -> NonDefaultSetConfig { | |||
| let protocol = self.into_protocol_name(); | |||
| let max_notification_size = match self { | |||
| PeerSet::Validation => 1024 * 1024, | |||
There was a problem hiding this comment.
PoV are also sent on the ValidationProtocol, so message limits should be the same IMO
eskimor
approved these changes
Jan 19, 2021
eskimor
approved these changes
Jan 19, 2021
|
Waiting for commit status. |
ghost
merged commit
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
paritytech/substrate#7925
Adds an explicit maximum limit to the sizes of notifications that we can receive.