substrate #9202 companion: Multiple vesting schedules #3407
Conversation
emostov
added
B1-releasenotes
C3-medium
emostov
added
D3-trivial 🧸
|
/benchmark runtime kusama pallet_vesting |
|
Finished benchmark for branch: zeke-companion-multi-vest Benchmark: Benchmark Runtime Kusama Pallet cargo run --release --features=runtime-benchmarks -- benchmark --chain=kusama-dev --steps=50 --repeat=20 --pallet=pallet_vesting --extrinsic="*" --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/kusama/src/weights/ ResultsCompiling sp-std v3.0.0 (https://github.com/paritytech/substrate?branch=master#baf37363) Caused by: --- stderr �[0m�[1m�[33mwarning�[0m�[0m�[1m: function is never used: �[0m�[1m�[33mwarning�[0m�[0m�[1m: 2 warnings emitted�[0m �[0m�[0m�[1m�[32m Compiling�[0m sp-timestamp v3.0.0 (https://github.com/paritytech/substrate?branch=master#baf37363) �[0m�[1m�[38;5;9merror[E0407]�[0m�[0m�[1m: method �[0m�[1m�[38;5;9merror[E0407]�[0m�[0m�[1m: method �[0m�[1m�[38;5;9merror[E0407]�[0m�[0m�[1m: method �[0m�[1m�[38;5;9merror[E0407]�[0m�[0m�[1m: method �[0m�[1m�[38;5;9merror[E0407]�[0m�[0m�[1m: method �[0m�[1m�[38;5;9merror[E0437]�[0m�[0m�[1m: type �[0m�[1m�[38;5;9merror[E0050]�[0m�[0m�[1m: method �[0m�[1m�[38;5;9merror[E0050]�[0m�[0m�[1m: method �[0m�[1m�[38;5;9merror[E0050]�[0m�[0m�[1m: method �[0m�[1m�[38;5;9merror[E0050]�[0m�[0m�[1m: method �[0m�[1m�[38;5;9merror[E0046]�[0m�[0m�[1m: not all trait items implemented, missing: �[0m�[1m�[38;5;9merror�[0m�[0m�[1m: aborting due to 12 previous errors�[0m �[0m�[1mSome errors have detailed explanations: E0046, E0050, E0407, E0437.�[0m To learn more, run the command again with --verbose. |
|
Assuming a Below is a map of 3 -> 102 // closest to 2^7
7 -> 238 // closest to 2^8
14 -> 504 // closest to 2^9
24 -> 816
30 -> 1020 // closest to 2^10
50 -> 1700
60 -> 2040 // closest to 2^11EDIT: according to Here is a test showing how I measured: https://github.com/paritytech/polkadot/pull/3407/files#diff-e5e76e02c0d16e79c70b024cbe3c6ea56f3249382a0f987ba203c34fcb40ed66R1598-R1610 |
runtime/test-runtime/src/lib.rs
Outdated
| @@ -433,7 +433,7 @@ impl claims::Config for Runtime { | |||
| } | |||
|
|
|||
| parameter_types! { | |||
| pub storage MinVestedTransfer: Balance = 100 * DOLLARS; | |||
| pub const MinVestedTransfer: Balance = 100 * DOLLARS; | |||
There was a problem hiding this comment.
why is this change being made?
sounds like instead you should be placing something within a externalities environment instead of doing this
|
Waiting for commit status. |
ghost
merged commit 
* master: backing-availability-audit: Move ErasureChunk Proof to BoundedVec (#3626) Substrate Companion #9575 (#3695) Fill up requests slots via `launch_parallel_requests` (#3681) Bump serde_json from 1.0.64 to 1.0.66 (#3669) substrate #9202 companion: Multiple vesting schedules (#3407) XCM: Introduce versioning to dispatchables' params (#3693) remove dead_code from chain selection test (#3685) Improve MultiLocation conversion functions in xcm-procedural (#3690)
substrate companion: paritytech/substrate#9202
Areas for feedback:
MaxVestingSchedulesbe for each runtime? I have initially set it to 24, which is based on if you get 1 schedule a month you can go 2 years without merging any schedules; but this is a very arbitrary goal.TODO: