This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
co #10662: Require MaxEncodedLen per default
#4746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The MaxEncodedLen trait is now enforced by default in Substrate. All pallets missing an implementation need to be marked with `without_storage_info` now. Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
ggwpez
added
A4-awaitingci
A4-companion
ggwpez
requested review from
acatangiu,
antonio-dropulic,
svyatonik and
tomusdrw
as code owners
ggwpez
removed request for
tomusdrw,
svyatonik,
acatangiu and
antonio-dropulic
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
ggwpez
added
C1-low
shawntabrizi
approved these changes
Jan 19, 2022
ggwpez
added
B0-silent
kianenigma
approved these changes
Jan 20, 2022
|
Waiting for commit status. |
|
Merge cancelled due to error. Error: Checks failed for dd84aa8 |
|
bot merge |
This was referenced Jan 31, 2022
Wizdave97
pushed a commit
to ComposableFi/polkadot
that referenced
this pull request
Feb 3, 2022
* Add `without_storage_info`
The MaxEncodedLen trait is now enforced by default in Substrate.
All pallets missing an implementation need to be marked with
`without_storage_info` now.
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* Remove `generate_storage_info`
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* Add more `without_storage_info`
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* update lockfile for {"substrate"}
Co-authored-by: parity-processbot <>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey it's my first MR in Polkadot 😉 I'm not sure with the
B-*andD-*labels, leaving them out for now.Change:
without_storage_infoto all pallets that miss an implementation forMaxEncodedLengenerate_storage_infosince it is not applied per-defaultcompanion to paritytech/substrate#10662
Cumulus companion: paritytech/cumulus#917