This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Cleanup macro magic #5270
Merged
Cleanup macro magic #5270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
ggwpez
added
B0-silent
|
bot rebase |
|
Rebasing |
bkchr
approved these changes
May 31, 2022
shawntabrizi
approved these changes
Jun 1, 2022
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
|
bot merge |
al3mart
pushed a commit
that referenced
this pull request
Jul 14, 2022
* Cleanup macro magic Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * Make sign_call infallible Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * Fix build Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * cargo update -p sp-io Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> Co-authored-by: parity-processbot <>
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#5137 introduced some ugly macros which I now cleaned up:
with_signed_payload!andsigned_payload!with_client!to provide the concrete runtimeBenchmarkCallSignerand implement it for all 4 runtime clientsBenchmarkCallSignertogether with thewith_client!macro to implementframe_benchmarking_cli::ExtrinsicBuilderin a cleaner wayThere now is some copy&paste code for 3 runtimes, but I think having that in a macro would only incite misuse.