This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Replace async-std with tokio in PVF subsystem #6419
Merged
Merged
Commits on Dec 11, 2022
-
Configuration menu - View commit details
-
Copy full SHA for ec204fa - Browse repository at this point
Copy the full SHA ec204faView commit details
Commits on Dec 13, 2022
-
Rework workers to use
select!
instead of a mutexThe improvement in code readability is more important than the thread overhead.
Configuration menu - View commit details
-
Copy full SHA for 3abc804 - Browse repository at this point
Copy the full SHA 3abc804View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5fcc67d - Browse repository at this point
Copy the full SHA 5fcc67dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1574561 - Browse repository at this point
Copy the full SHA 1574561View commit details -
Configuration menu - View commit details
-
Copy full SHA for 451fae0 - Browse repository at this point
Copy the full SHA 451fae0View commit details
Commits on Dec 18, 2022
-
Update node/core/pvf/src/worker_common.rs
Co-authored-by: Bastian Köcher <info@kchr.de>
Configuration menu - View commit details
-
Copy full SHA for fc4c28b - Browse repository at this point
Copy the full SHA fc4c28bView commit details -
Update node/core/pvf/src/worker_common.rs
Co-authored-by: Bastian Köcher <info@kchr.de>
Configuration menu - View commit details
-
Copy full SHA for 1dde78b - Browse repository at this point
Copy the full SHA 1dde78bView commit details -
Configuration menu - View commit details
-
Copy full SHA for da31a48 - Browse repository at this point
Copy the full SHA da31a48View commit details -
Merge remote-tracking branch 'origin/m-cat/replace-async-std-pvf' int…
…o m-cat/replace-async-std-pvf
Configuration menu - View commit details
-
Copy full SHA for 35a0c79 - Browse repository at this point
Copy the full SHA 35a0c79View commit details -
Configuration menu - View commit details
-
Copy full SHA for e1c2cf3 - Browse repository at this point
Copy the full SHA e1c2cf3View commit details
Commits on Dec 19, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 077a123 - Browse repository at this point
Copy the full SHA 077a123View commit details -
Configuration menu - View commit details
-
Copy full SHA for e0d4b9e - Browse repository at this point
Copy the full SHA e0d4b9eView commit details
Commits on Dec 20, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 2353747 - Browse repository at this point
Copy the full SHA 2353747View commit details -
Configuration menu - View commit details
-
Copy full SHA for 28d4062 - Browse repository at this point
Copy the full SHA 28d4062View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3964aca - Browse repository at this point
Copy the full SHA 3964acaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7057518 - Browse repository at this point
Copy the full SHA 7057518View commit details -
Configuration menu - View commit details
-
Copy full SHA for e6ba098 - Browse repository at this point
Copy the full SHA e6ba098View commit details -
Configuration menu - View commit details
-
Copy full SHA for e094f80 - Browse repository at this point
Copy the full SHA e094f80View commit details -
Configuration menu - View commit details
-
Copy full SHA for c09377a - Browse repository at this point
Copy the full SHA c09377aView commit details
Commits on Dec 22, 2022
-
Fix a couple of potential minor data races.
First data race was due to logging in the CPU monitor thread even if the job (other thread) finished. It can technically finish before or after the log. Maybe best would be to move this log to the `select!`s, where we are guaranteed to have chosen the timed-out branch, although there would be a bit of duplication. Also, it was possible for this thread to complete before we executed `finished_tx.send` in the other thread, which would trigger an error as the receiver has already been dropped. And right now, such a spurious error from `send` would be returned even if the job otherwise succeeded.
Configuration menu - View commit details
-
Copy full SHA for 05d1865 - Browse repository at this point
Copy the full SHA 05d1865View commit details
Commits on Jan 5, 2023
-
Configuration menu - View commit details
-
Copy full SHA for b0c2434 - Browse repository at this point
Copy the full SHA b0c2434View commit details
Commits on Jan 9, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 5cc477c - Browse repository at this point
Copy the full SHA 5cc477cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0f4ac06 - Browse repository at this point
Copy the full SHA 0f4ac06View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.