This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Remove BoundedVec half-impls in xcm #6636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KiChjang
added
A0-please_review
bkchr
approved these changes
Jan 27, 2023
ggwpez
approved these changes
Jan 27, 2023
mrcnski
approved these changes
Jan 29, 2023
|
Must bump substrate after paritytech/substrate#13243 is merged. |
3 tasks
gavofyork
reviewed
Feb 7, 2023
| // Eventually it should be replaced by `DispatchError::max_encoded_len()`. | ||
| let worst_error = || MaybeErrorCode::Error(vec![0; 1024]); | ||
| let worst_error = || -> MaybeErrorCode { | ||
| vec![0; MaxDispatchErrorLen::get() as usize].into() |
gavofyork
approved these changes
Feb 7, 2023
|
Are we waiting for cumulus to build in CI? |
|
Yes, that is the case. |
|
bot merge |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #6572.
This PR removes the half-impls of bounded vectors in the
xcmcrate and replaces them withBoundedVecinbounded-collections.