This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Unqueue panicking extrinsics from the pool #13911
Labels
J0-enhancement
An additional feature request.
Comments
bkchr
added a commit
that referenced
this issue
Apr 13, 2023
The check was intially added by: #5121 But a later pr fixed it properly: #9789 TLDR: We don't need to check for skipped anymore, as we already remove all transactions that are being unlocked by an invalid transactions and thus, we will not tag them as invalid directly because the nonce for example is incorrect. Fixes: #13911
bkchr
added a commit
that referenced
this issue
Apr 14, 2023
The check was intially added by: #5121 But a later pr fixed it properly: #9789 TLDR: We don't need to check for skipped anymore, as we already remove all transactions that are being unlocked by an invalid transactions and thus, we will not tag them as invalid directly because the nonce for example is incorrect. Fixes: #13911
nathanwhit
pushed a commit
to nathanwhit/substrate
that referenced
this issue
Jul 19, 2023
The check was intially added by: paritytech#5121 But a later pr fixed it properly: paritytech#9789 TLDR: We don't need to check for skipped anymore, as we already remove all transactions that are being unlocked by an invalid transactions and thus, we will not tag them as invalid directly because the nonce for example is incorrect. Fixes: paritytech#13911
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Is there an existing issue?
Experiencing problems? Have you tried our Stack Exchange first?
Motivation
After a runtime upgrade there is no guarantee that extrinsics that already existed in the transaction pool are decodeable anymore. Of course they are discarded at block production, but they still live in the pool, occupying memory space, and poluting the logs with panic backtraces.
Request
Currently transactions considered Invalid are unqueued, so the proposal is do the same with extrinsics that panic.
Solution
No response
Are you willing to help with this request?
Yes!
The text was updated successfully, but these errors were encountered: