This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Add vote and seconded events to Democracy pallet.
#10352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkchr
approved these changes
Nov 24, 2021
bkchr
added
A0-please_review
kianenigma
approved these changes
Nov 26, 2021
kianenigma
reviewed
Nov 26, 2021
kianenigma
changed the title
vote and seconded events to Democracy pallet.
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
gui1117
approved these changes
Nov 29, 2021
|
I don't know why CI is not happy, maybe merge master ? |
kianenigma
added
A1-onice
and removed
A0-please_review
bkchr
added
A0-please_review
JoshOrndorff
added a commit
to moonbeam-foundation/substrate
that referenced
this pull request
Dec 1, 2021
* add the events * spec_version * Update bin/node/runtime/src/lib.rs Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com> Co-authored-by: Alan Sapede <alan.sapede@gmail.com> Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com> (cherry picked from commit 270fac3)
JoshOrndorff
added a commit
to moonbeam-foundation/substrate
that referenced
this pull request
Dec 1, 2021
…) (#23) * add the events * spec_version * Update bin/node/runtime/src/lib.rs Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com> Co-authored-by: Alan Sapede <alan.sapede@gmail.com> Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com> (cherry picked from commit 270fac3)
tgmichel
added a commit
to moonbeam-foundation/substrate
that referenced
this pull request
Dec 3, 2021
…) (#23) * add the events * spec_version * Update bin/node/runtime/src/lib.rs Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com> Co-authored-by: Alan Sapede <alan.sapede@gmail.com> Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com> (cherry picked from commit 270fac3) (cherry picked from commit f0d3cd3)
tgmichel
added a commit
to moonbeam-foundation/substrate
that referenced
this pull request
Jan 10, 2022
…) (#23) * add the events * spec_version * Update bin/node/runtime/src/lib.rs Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com> Co-authored-by: Alan Sapede <alan.sapede@gmail.com> Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com> (cherry picked from commit 270fac3) (cherry picked from commit f0d3cd3) (cherry picked from commit 24a1737)
tgmichel
added a commit
to moonbeam-foundation/substrate
that referenced
this pull request
Jan 18, 2022
…) (#23) * add the events * spec_version * Update bin/node/runtime/src/lib.rs Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com> Co-authored-by: Alan Sapede <alan.sapede@gmail.com> Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com> (cherry picked from commit 270fac3) (cherry picked from commit f0d3cd3) (cherry picked from commit 24a1737)
grishasobol
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Mar 28, 2022
* add the events * spec_version * Update bin/node/runtime/src/lib.rs Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com> Co-authored-by: Alan Sapede <alan.sapede@gmail.com> Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
ark0f
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Feb 27, 2023
* add the events * spec_version * Update bin/node/runtime/src/lib.rs Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com> Co-authored-by: Alan Sapede <alan.sapede@gmail.com> Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10283
This PR adds two new events to pallet democracy,
Secondedfor when a user seconds a proposal. AndVotedfor when a user votes on a referendum.Question about the Polkadot: This only adds the events to the pallet. It does not require any code changes in Polkadot. Shall I still open a Polkadot PR that updates its cargo.lock file? If so shall I wait until this is merged so I know what sha to point to?
cc @thiolliere