-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Add baseline benchmark for sr25519 verification #10414
Conversation
/benchmark runtime pallet frame_benchmarking |
Benchmark Runtime Pallet for branch "zeke-bench-sig-verification" with command cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=frame_benchmarking --extrinsic="*" --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/benchmarking/src/weights.rs --template=./.maintain/frame-weight-template.hbs Results
|
…path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=frame_benchmarking --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/benchmarking/src/weights.rs --template=./.maintain/frame-weight-template.hbs
frame/benchmarking/src/baseline.rs
Outdated
assert_eq!( | ||
sig.verify(&msg[..], &public), | ||
true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would be good to verify that this is exactly what we want to measure versus a batch signature verification?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am most interested in the speed of a single verification like this https://github.com/paritytech/polkadot/blob/5afceea8b77d27ac6c3eaf500160e9f34807c26b/runtime/parachains/src/disputes.rs#L1221
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sounds good then
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>
bot merge |
Error: Checks failed for 4271764 |
bot merge |
Error: Checks failed for 4271764 |
* Add baseline benchmark for sr25519 verification * cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=frame_benchmarking --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/benchmarking/src/weights.rs --template=./.maintain/frame-weight-template.hbs * Register keystore for correct test externalities * Update frame/benchmarking/src/baseline.rs Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com> * fix build Co-authored-by: Parity Bot <admin@parity.io> Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>
* Add baseline benchmark for sr25519 verification * cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=frame_benchmarking --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/benchmarking/src/weights.rs --template=./.maintain/frame-weight-template.hbs * Register keystore for correct test externalities * Update frame/benchmarking/src/baseline.rs Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com> * fix build Co-authored-by: Parity Bot <admin@parity.io> Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>
The weight of sr25519 signature verification is a major factor in the performance of the polkadot parachains runtime
enter
inherent and its creation.skip cumulus-dependent-check