This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Fix slashing migration to v10 #11924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kianenigma
added
A0-please_review
github-actions
bot
added
A3-in_progress
kianenigma
added
A0-please_review
|
In this PR you can also change the default version i caught was behind? In fact you can now use some |
shawntabrizi
approved these changes
Jul 27, 2022
bkchr
approved these changes
Jul 28, 2022
|
bot merge |
chevdor
added a commit
that referenced
this pull request
Jul 28, 2022
* Fix slashing migration to v10 * add some logs * Fix default version * fmt * Move doc to struct Co-authored-by: Wilfried Kopp <wilfried@parity.io>
15 tasks
chevdor
added a commit
that referenced
this pull request
Jul 28, 2022
DaviRain-Su
pushed a commit
to octopus-network/substrate
that referenced
this pull request
Aug 23, 2022
* Fix slashing migration to v10 * add some logs * Fix default version * fmt * Move doc to struct Co-authored-by: Wilfried Kopp <wilfried@parity.io>
2 tasks
louismerlin
added
D1-audited 👍
ark0f
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Feb 27, 2023
* Fix slashing migration to v10 * add some logs * Fix default version * fmt * Move doc to struct Co-authored-by: Wilfried Kopp <wilfried@parity.io>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small fix to the migration of #11823
Problem: If some slashes already exist in
UnappliedSlashes, they will probably never be triggered in the new logic, since we lookup only a specific key of this map at the beginning of the era.Solution: Try and apply all pending slashes one last time before going to the new logic.
What I have written now in code is not ideal, but good enough that under normal conditions we survive. If an attacker wants to create more than 512 slash reports or such, it still needs a manual intervention.