Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Add BoundedVec::sort_by_key #11998

Merged
merged 1 commit into from
Aug 10, 2022
Merged

Conversation

ggwpez
Copy link
Member

@ggwpez ggwpez commented Aug 9, 2022

Per title. Needed for #11996

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez ggwpez added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Aug 9, 2022
Copy link
Contributor

@hbulgarini hbulgarini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! is necessary to have this feature for BoundedVec.

@shawntabrizi
Copy link
Member

bot merge

@paritytech-processbot
Copy link

Waiting for commit status.

@paritytech-processbot paritytech-processbot bot merged commit ef433a8 into master Aug 10, 2022
@paritytech-processbot paritytech-processbot bot deleted the oty-bounded-vec-sort-by-key branch August 10, 2022 08:39
DaviRain-Su pushed a commit to octopus-network/substrate that referenced this pull request Aug 23, 2022
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
ark0f pushed a commit to gear-tech/substrate that referenced this pull request Feb 27, 2023
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants