fix: Fixes substrate-node-template docker issues

bin/node-template/README.md

@@ -162,6 +162,8 @@ First, install [Docker](https://docs.docker.com/get-docker/) and [Docker Compose
 
 Then run the following command to start a single node development chain.
 
+> If you get an error that tcp port address is already in use then find an available port to use for the host port in docker-compose.yml (i.e. "<HOST_PORT>:9944").
+
 ```sh
 ./scripts/docker_run.sh
 ```

bin/node-template/docker-compose.yml

@@ -1,17 +1,20 @@
-version: "3.2"
-
 services:
+# first line of this file must be reserved for use by ./scripts/docker_run.sh
   dev:
     container_name: node-template
     image: paritytech/ci-linux:production
-    working_dir: /var/www/node-template
+    working_dir: /var/www/node-template/node
     ports:
       - "9944:9944"
     environment:
       - CARGO_HOME=/var/www/node-template/.cargo
     volumes:
       - .:/var/www/node-template
-      - type: bind
-        source: ./.local
-        target: /root/.local
+      - ./.cargo/registry:/root/.cargo/registry
+      - ./.local:/root/.local
+      - ../../.git:/var/www/node-template/.git
+      - ../../frame:/var/frame
+      - ../../utils:/var/utils
+      - ../../client:/var/client
+      - ../../primitives:/var/primitives
     command: bash -c "cargo build --release && ./target/release/node-template --dev --ws-external"

bin/node-template/scripts/docker_run.sh

@@ -2,9 +2,72 @@
 # This script is meant to be run on Unix/Linux based systems
 set -e
 
-echo "*** Start Substrate node template ***"
-
+printf "*** Start Substrate node template ***\n"
+SCRIPT_DIR=$(realpath "$(dirname "${BASH_SOURCE[0]}")")
+PARENT_DIR=$(dirname "$SCRIPT_DIR")
+mkdir -p "$PARENT_DIR/.local"
+mkdir -p "$PARENT_DIR/.cargo/registry"
 cd $(dirname ${BASH_SOURCE[0]})/..
 
-docker-compose down --remove-orphans
-docker-compose run --rm --service-ports dev $@
+modify_first_line_of_docker_compose() {
+    local first_line=$1
+    sed -i "1s/.*/$first_line/" $PARENT_DIR/docker-compose.yml
+}
+
+printf "Searching for docker-compose executable...\n"
+
+if ! [ -x "$(command -v docker-compose)" ]; then
+    printf "Skipping docker-compose since executable is not installed.\n"
+else
+    printf "Detected docker-compose executable.\n"
+    exit_code=$(docker-compose version; status=$?; echo $status)
+    # get the last character captured by $? since it may also include command output first
+    last_char=${exit_code: -1}
+
+    # prefix last char with random character incase last char is 0 but not an exit code
+    if [[ "x${last_char}" == "x0" && "$(docker-compose version)" =~ " 1." ]]; then
+        printf "Detected legacy docker-compose version 1.x. Using Compose File Format 1.\n"
+        # temporarily comment out first line `services:` of ../docker-compose.yml
+        modify_first_line_of_docker_compose "#services:"
+        docker-compose down --remove-orphans
+        docker-compose run --rm --service-ports dev $@
+        # uncomment again the first line `services:` of ../docker-compose.yml
+        modify_first_line_of_docker_compose "services:"
+        exit
+    fi
+
+    exit_code=$(docker-compose compose version; status=$?; echo $status)
+    last_char=${exit_code: -1}
+
+    if [[ "x${last_char}" == "x0" && "$(docker-compose compose version)" =~ " v2." ]]; then
+        printf "Detected legacy docker-compose version 2.x. Using Compose File Format 2+.\n"
+        # switch back to default `services:` incase was temporarily commented out
+        modify_first_line_of_docker_compose "services:"
+        docker-compose compose down --remove-orphans
+        docker-compose compose run --rm --service-ports dev $@
+        exit
+    fi
+
+    printf "Unknown or unsupported version of docker-compose. Skipping...\n"
+fi
+
+if ! [ -x "$(command -v docker)" ]; then
+    printf "Skipping docker since docker executable is not installed.\n"
+else
+    printf "Detected docker executable.\n"
+    exit_code=$(docker compose version; status=$?; echo $status)
+    last_char=${exit_code: -1}
+
+    if [[ "x${last_char}" == "x0" ]]; then
+        printf "Detected docker compose subcommand.\n"
+        # switch back to default `services:` incase was temporarily commented out
+        modify_first_line_of_docker_compose "services:"
+        docker compose down --remove-orphans
+        docker compose run --rm --service-ports dev $@
+    else
+        printf "Skipping docker since docker executable subcommand not supported.\n"
+    fi
+    exit
+fi
+
+printf "Error: Unable to detect any docker compose installation.\n"

client/cli/src/runner.rs

@@ -190,7 +190,7 @@ impl<C: SubstrateCli> Runner<C> {
 pub fn print_node_infos<C: SubstrateCli>(config: &Configuration) {
 	info!("{}", C::impl_name());
 	info!("✌️  version {}", C::impl_version());
-	info!("❤️  by {}, {}-{}", C::author(), C::copyright_start_year(), Local::today().year());
+	info!("❤️  by {}, {}-{}", C::author(), C::copyright_start_year(), Local::now().year());
 	info!("📋 Chain specification: {}", config.chain_spec.name());
 	info!("🏷  Node name: {}", config.network.node_name);
 	info!("👤 Role: {}", config.display_role());