This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
IntegrityTest implementation should be feature gated
#13094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The initial implementation for the old declarative macros is still feature gating the implementation. As we only call this in a test, there is no need to have this compiled for wasm.
bkchr
added
A2-insubstantial
ggwpez
reviewed
Jan 7, 2023
| @@ -191,6 +191,7 @@ pub fn expand_hooks(def: &mut Def) -> proc_macro2::TokenStream { | |||
| } | |||
| } | |||
|
|
|||
| #[cfg(feature = "std")] | |||
There was a problem hiding this comment.
The Polkadot comp CI fails.
Looks like mock_msg_pallet does not have an std feature and therefore tries to compile the integrity tests without it.
In these cases we cannot run the integrity test, so the __construct_runtime_integrity_test should probably also be std-gated.
Or we fix the mock_msg_queue to have a std feature 🤷♂️
kianenigma
approved these changes
Jan 8, 2023
ggwpez
approved these changes
Jan 11, 2023
|
bot merge |
This was referenced Feb 22, 2023
6 tasks
15 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The initial implementation for the old declarative macros is still feature gating the implementation. As we only call this in a test, there is no need to have this compiled for wasm.