This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
pallet-assets callback improvement #13543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitry-markin
added
A0-please_review
|
Can someone else also please take a look? 🙏 |
gavofyork
reviewed
Mar 13, 2023
| @@ -661,8 +661,8 @@ impl<T: Config<I>, I: 'static> Pallet<T, I> { | |||
| status: AssetStatus::Live, | |||
| }, | |||
| ); | |||
| ensure!(T::CallbackHandle::created(&id, &owner).is_ok(), Error::<T, I>::CallbackFailed); | |||
There was a problem hiding this comment.
This relies on transactional stroage since the insert above happens after the failure here.
There was a problem hiding this comment.
This was intentional since my understanding is that this is the default behavior (also got this comment below).
I also thought it would be good to have Assets entry in the DB before the callback (just in case the data from it is needed for the callback).
Open to suggestions though 🙂
There was a problem hiding this comment.
you can use require_transactional to annotate it
substrate/frame/support/src/lib.rs
Line 657 in 959c5b6
kianenigma
approved these changes
Mar 13, 2023
|
bot merge |
ukint-vs
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Apr 10, 2023
15 tasks
nathanwhit
pushed a commit
to nathanwhit/substrate
that referenced
this pull request
Jul 19, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves
AssetsCallbacktrait by introducingResult<(), ()>as the return type.This allows callback to inform the pallet whether the asset creation (or destruction) should complete or not.
Also moves the
destroyedcallback invocation todo_finish_destroyfunction.