Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

sc-slots: Cleanup #13590

Merged
merged 1 commit into from
Mar 13, 2023
Merged

sc-slots: Cleanup #13590

merged 1 commit into from
Mar 13, 2023

Conversation

bkchr
Copy link
Member

@bkchr bkchr commented Mar 13, 2023

Calculate remaining proposal duration once and also use proposal time as timeout for creating the inherent data.

@bkchr
sc-slots: Cleanup
db71f77 
Calculate remaining proposal duration once and also use proposal time as timeout for creating the
inherent data.
@bkchr bkchr added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Mar 13, 2023
@bkchr bkchr requested a review from a team March 13, 2023 10:53
@bkchr bkchr requested a review from andresilva as a code owner March 13, 2023 10:53
@davxy davxy requested a review from a team March 13, 2023 13:16
@skunert
Copy link
Contributor

skunert commented Mar 13, 2023 •
edited
Loading

Calculate remaining proposal duration once and also use proposal time as timeout for creating the inherent data.

Nit: slight mismatch between description and the code. Remaining proposal duration is calculated twice, did you intend to pass it to create_inherent data?

@bkchr
Copy link
Member Author

bkchr commented Mar 13, 2023

Calculate remaining proposal duration once and also use proposal time as timeout for creating the inherent data.

Nit: slight mismatch between description and the code. Remaining proposal duration is calculated twice, did you intend to pass it to create_inherent data?

No the code is as intended ;) I more meant calling the remaining_proposal_duration function :D

@bkchr bkchr merged commit 3a94009 into master Mar 13, 2023
@bkchr bkchr deleted the bkchr-slots-cleanup branch March 13, 2023 21:46
@nazar-pc nazar-pc mentioned this pull request Apr 2, 2023
Merged
1 task
@kiltbot kiltbot mentioned this pull request Apr 3, 2023
Closed
ukint-vs pushed a commit to gear-tech/substrate that referenced this pull request Apr 10, 2023
@bkchr @ukint-vs
sc-slots: Cleanup (paritytech#13590)
b5e6a28 
Calculate remaining proposal duration once and also use proposal time as timeout for creating the
inherent data.
@kacperzuk-neti kacperzuk-neti mentioned this pull request Jun 23, 2023
Merged
15 tasks
nathanwhit pushed a commit to nathanwhit/substrate that referenced this pull request Jul 19, 2023
@bkchr @nathanwhit
sc-slots: Cleanup (paritytech#13590)
1415b0a 
Calculate remaining proposal duration once and also use proposal time as timeout for creating the
inherent data.
@dmitrylavrenov dmitrylavrenov mentioned this pull request Nov 28, 2023
Closed
46 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@skunert skunert skunert approved these changes

@davxy davxy davxy approved these changes

@andresilva andresilva Awaiting requested review from andresilva

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bkchr @skunert @davxy