This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
CI: Investigate why RUSTFLAGS differs on master and PRs
#13686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rcny
added
A3-in_progress
|
bot rebase |
|
Rebased |
rcny
added
A2-insubstantial
rcny
changed the title
RUSTFLAGS differ on master and PRs
rcny
changed the title
RUSTFLAGS differ on master and PRsRUSTFLAGS differs on master and PRs
|
I need to merge this before this night's cache rollout, so I'll proceed. |
ghost
merged commit
pgherveou
pushed a commit
that referenced
this pull request
Apr 4, 2023
gpestana
pushed a commit
that referenced
this pull request
Apr 23, 2023
15 tasks
nathanwhit
pushed a commit
to nathanwhit/substrate
that referenced
this pull request
Jul 19, 2023
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
RUSTFLAGSenvironment variable is the same formasterand PRs. It's set to-Cdebug-assertions=y -Dwarningsfor many jobs, butmaster's cache here has only-Cdebug-assertions=yin therustflagsfingerprint value, no mentions of-Dwarnings, that's why the cache gets invalidated.More investigation is needed on what could lead to the situation where a fingerprint lacks the part of the
rustflags, but, again, theRUSTFLAGSis set to the same value between same jobs on different refs.