This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Remove HeaderBackend requirement from AuthorityDiscovery and NetworkWorker #13730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skunert
added
A0-please_review
bkchr
approved these changes
Mar 27, 2023
altonen
approved these changes
Mar 27, 2023
|
bot merge |
davxy
approved these changes
Mar 28, 2023
| @@ -688,7 +688,7 @@ impl NetworkConfiguration { | |||
| } | |||
|
|
|||
| /// Network initialization parameters. | |||
| pub struct Params<Client> { | |||
| pub struct Params<Block: BlockT> { | |||
There was a problem hiding this comment.
Nit. Can this be generic over Hash only?
There was a problem hiding this comment.
aaakkk 🤣 Late again. Just a silly nit anyway
bkchr
pushed a commit
that referenced
this pull request
Apr 4, 2023
…orker (#13730) * Remove `HeaderBackend` requirement from `NetworkWorker` * Remove HeaderBackend from authority-discovery
pgherveou
pushed a commit
that referenced
this pull request
Apr 4, 2023
…orker (#13730) * Remove `HeaderBackend` requirement from `NetworkWorker` * Remove HeaderBackend from authority-discovery
gpestana
pushed a commit
that referenced
this pull request
Apr 23, 2023
…orker (#13730) * Remove `HeaderBackend` requirement from `NetworkWorker` * Remove HeaderBackend from authority-discovery
15 tasks
nathanwhit
pushed a commit
to nathanwhit/substrate
that referenced
this pull request
Jul 19, 2023
…orker (paritytech#13730) * Remove `HeaderBackend` requirement from `NetworkWorker` * Remove HeaderBackend from authority-discovery
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NetworkWorker and AuthorityDiscovery took in a client that needed to implement
HeaderBackendjust to fetch the best hash/genesis hash. Shuffling around the code a bit can eliminate this client and allow some nice refactorings in cumulus.cumulus companion: paritytech/cumulus#2385