Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

FRAME: Minor fix for failsafe. #13741

Merged
merged 5 commits into from
Apr 1, 2023
Merged

FRAME: Minor fix for failsafe. #13741

merged 5 commits into from
Apr 1, 2023

Conversation

gavofyork
Copy link
Member

@gavofyork gavofyork added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit T1-runtime This PR/Issue is related to the topic “runtime”. labels Mar 28, 2023
@gavofyork gavofyork mentioned this pull request Mar 28, 2023
Merged
28 tasks
@paritytech-cicd-pr
Copy link

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2607101

@bkchr bkchr merged commit d6f278b into master Apr 1, 2023
@bkchr bkchr deleted the gav-fix-minmax branch April 1, 2023 21:59
pgherveou pushed a commit that referenced this pull request Apr 4, 2023
@gavofyork @muharem @pgherveou
FRAME: Minor fix for failsafe. (#13741)
89f70ac 
* max instead of min

* Remove debug stuff

* remove debug code

* warn log on no provider ref

* format string for log

---------

Co-authored-by: muharem <ismailov.m.h@gmail.com>
gpestana pushed a commit that referenced this pull request Apr 23, 2023
@gavofyork @muharem @gpestana
FRAME: Minor fix for failsafe. (#13741)
76adcec 
* max instead of min

* Remove debug stuff

* remove debug code

* warn log on no provider ref

* format string for log

---------

Co-authored-by: muharem <ismailov.m.h@gmail.com>
@github-actions github-actions bot mentioned this pull request Jun 15, 2023
Closed
@kacperzuk-neti kacperzuk-neti mentioned this pull request Jun 23, 2023
Merged
15 tasks
nathanwhit pushed a commit to nathanwhit/substrate that referenced this pull request Jul 19, 2023
@gavofyork @muharem @nathanwhit
FRAME: Minor fix for failsafe. (paritytech#13741)
b92da98 
* max instead of min

* Remove debug stuff

* remove debug code

* warn log on no provider ref

* format string for log

---------

Co-authored-by: muharem <ismailov.m.h@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@xlc xlc xlc left review comments

@muharem muharem muharem approved these changes

@ggwpez ggwpez ggwpez approved these changes

@KiChjang KiChjang KiChjang approved these changes

@kianenigma kianenigma kianenigma approved these changes

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit T1-runtime This PR/Issue is related to the topic “runtime”.
Projects
Runtime / FRAME
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@gavofyork @paritytech-cicd-pr @xlc @KiChjang @kianenigma @muharem @ggwpez @bkchr