This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Move registration of ReadRuntimeVersionExt to ExecutionExtension
#13820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of registering `ReadRuntimeVersionExt` in `sp-state-machine` it is moved to `ExecutionExtension` which provides the default extensions.
bkchr
added
A0-please_review
koute
approved these changes
Apr 5, 2023
| @@ -810,7 +810,7 @@ where | |||
| } | |||
|
|
|||
| /// Build all extensions that we typically use. | |||
| pub(crate) fn full_extensions() -> Extensions { | |||
| pub(crate) fn full_extensions<H: HostFunctions>(wasm_executor: WasmExecutor<H>) -> Extensions { | |||
There was a problem hiding this comment.
Considering the bounds on ReadRuntimeVersionExt::new maybe this would be better?
Suggested change
| pub(crate) fn full_extensions<H: HostFunctions>(wasm_executor: WasmExecutor<H>) -> Extensions { | |
| pub(crate) fn full_extensions(read_runtime_version: impl ReadRuntimeVersionExt + 'static) -> Extensions { |
Probably doesn't matter though; feel free to ignore.
skunert
approved these changes
Apr 5, 2023
| @@ -427,6 +427,7 @@ mod tests { | |||
| Default::default(), | |||
| None, | |||
| None, | |||
| Arc::new(executor.clone()), | |||
There was a problem hiding this comment.
Suggested change
| Arc::new(executor.clone()), | |
| Arc::new(executor), |
gpestana
pushed a commit
that referenced
this pull request
Apr 23, 2023
…13820) Instead of registering `ReadRuntimeVersionExt` in `sp-state-machine` it is moved to `ExecutionExtension` which provides the default extensions.
15 tasks
nathanwhit
pushed a commit
to nathanwhit/substrate
that referenced
this pull request
Jul 19, 2023
…aritytech#13820) Instead of registering `ReadRuntimeVersionExt` in `sp-state-machine` it is moved to `ExecutionExtension` which provides the default extensions.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of registering
ReadRuntimeVersionExtinsp-state-machineit is moved toExecutionExtensionwhich provides the default extensions.