Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Update the frame-weight-template to use PhantomData from core #13844

Merged

Conversation

AlexD10S
Copy link
Contributor

@AlexD10S AlexD10S commented Apr 6, 2023

Update the file frame-weight-template.hbs to use core::marker::PhantomData instead of sp_std::marker::PhantomData, so no need to import the sp-std just for this type.

And updated manually the pallet_template from the node_template.

This change was suggested in a comment in this PR #13817

@AlexD10S AlexD10S added B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Apr 6, 2023
@AlexD10S AlexD10S requested a review from ggwpez April 6, 2023 12:57
@AlexD10S AlexD10S self-assigned this Apr 6, 2023
@ggwpez ggwpez added A0-please_review Pull request needs code review. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Apr 6, 2023
@ggwpez
Copy link
Member

ggwpez commented Apr 6, 2023

bot merge

@paritytech-processbot paritytech-processbot bot merged commit 851a826 into master Apr 6, 2023
@paritytech-processbot paritytech-processbot bot deleted the alexd10s-modify-weights-template-imports branch April 6, 2023 16:19
nathanwhit pushed a commit to nathanwhit/substrate that referenced this pull request Jul 19, 2023
…tech#13844)

* update weights template and recalculate weights from pallet template

* update template file in benchmarking-cli
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants