Globally upgrade to syn 2.x and latest quote and proc_macro2 1x versions

[sam0x17]

polkadot companion: paritytech/polkadot#7022

Description

We have a lot of different versions of dtolnay's quote/syn/proc-macro2 crates floating around. Dtolnay recently came out with syn 2.x

This PR sets all versions of proc-macro2, syn, and quote to the versions listed below, which at the time of writing are the latest 1.x version for each crate (or 2.x in the case of syn)

This should improve compile-times since only one version of these crates will be compiled globally, and will also reduce confusing edge cases due to version differences

Crates Upgraded

proc-macro2 => 1.0.56
syn => 2.0.14
quote => 1.0.26

[sam0x17]

converting to draft because it looks like we might need some companions

[sam0x17]

cumulus is already on syn 2.x and the latest for the other crates so no need for a cumulus companion

[bkchr]

cumulus is already on syn 2.x and the latest for the other crates so no need for a cumulus companion

Then not updating syn to 2.x makes no sense.

[bkchr]

Could you please just update to 2.x for syn?

In general, cargo unifies across patch/minor releases which you already see with your pr here. You changed multiple Cargo.toml files, but the Cargo.lock wasn't changed. This means that we already used these versions.

[sam0x17]

Could you please just update to 2.x for syn?

In general, cargo unifies across patch/minor releases which you already see with your pr here. You changed multiple Cargo.toml files, but the Cargo.lock wasn't changed. This means that we already used these versions.

Yes, let me do that

[sam0x17]

actually @bkchr it seems to be non-trivial. Upgrading to syn 2.x I get a ton of errors on substrate. For some reason cumulus is fine with it though

[koute]

Yes, we should update to syn 2, but it might not be just a trivial version bump as there are breaking API changes between v1 and v2.

@sam0x17 From a practical point of view it'd be the best to just update the deps to v2 one-by-one and fix the errors as you go.

[bkchr]

actually @bkchr it seems to be non-trivial. Upgrading to syn 2.x I get a ton of errors on substrate. For some reason cumulus is fine with it though

Cumulus probably proc-macro isn't that complex and maybe uses an api that didn't changed!

[sam0x17]

note, will need to get drahnr/expander#6 merged if we want to do syn 2.x

[bkchr]

note, will need to get drahnr/expander#6 merged if we want to do syn 2.x

scale-codec also doesn't yet use syn 2.0. There are also probably plenty of other crates that are not yet ported. I don't see a reason to wait.

[sam0x17]

@bkchr I can't get polkadot to build with syn 2.0 without upgrading expander's syn to 2.0 as well. There is a very subtle conflict on syn::Error not being compatible between the latest 1.x and the latest 2.x, if you look at my latest push on the polkadot companion

Also, things that aren't ready to upgrade to syn 2 could just not use the new expander version and be fine I would think

side note: upgrading expander was as simple as changing the version in Cargo.toml, so should be backwards compatible generally (other than this particular issue I would think)

[bkchr]

There is no commit on the companion.

[sam0x17]

There is no commit on the companion.

Pushed an hour or so ago:

commit 8e840554ee01719067acbf68cf8dcf78251bad8b (HEAD -> sam-globally-upgrade-syn-quote, origin/sam-globally-upgrade-syn-quote)

[sam0x17]

This one causes the failure paritytech/polkadot@1c63df9

[sam0x17]

This is the error @bkchr, took me a good bit to figure out that it is because of syn versions:

I tried a bunch of things to fix it including creating a new wrapper type TokenStreamResultWrapper that has the proper impls but it was impossible to satisfy the compiler because expander is actually talking about a different syn::Error

[sam0x17]

So he accepted my PR, though no new release has been cut yet. I just pushed up a test commit manually updating the version of expander to use the latest git just to confirm that CI passes with it. Will remove that once he cuts a new release

[sam0x17]

bot rebase

[paritytech-processbot]

Error: Command 'Command { std: cd "/storage/repositories/substrate" && "git" "merge" "origin/master" "--no-ff" "--no-edit", kill_on_drop: false }' failed with status Some(1); output: no output

[KiChjang]

So he accepted my PR, though no new release has been cut yet. I just pushed up a test commit manually updating the version of expander to use the latest git just to confirm that CI passes with it. Will remove that once he cuts a new release

You don't really need to wait for him to publish -- you said before that paritytech-devs are owners of his crate on crates.io as well, correct? If so, you can just run cargo publish locally with the new version, and it will Just Work.

[sam0x17]

So he accepted my PR, though no new release has been cut yet. I just pushed up a test commit manually updating the version of expander to use the latest git just to confirm that CI passes with it. Will remove that once he cuts a new release

You don't really need to wait for him to publish -- you said before that paritytech-devs are owners of his crate on crates.io as well, correct? If so, you can just run cargo publish locally with the new version, and it will Just Work.

he published an hour after he accepted my PR apparently so we good

[sam0x17]

bot merge